You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/05/11 09:56:50 UTC

Review Request 47228: LENS-771 : Add test for multiple chain ref columns having subset chains

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47228/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-771
    https://issues.apache.org/jira/browse/LENS-771


Repository: lens


Description
-------

Added test for the issue and update example to have multiple chain ref columns.


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java 4c98d86 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 51ba636 
  lens-examples/src/main/resources/sales-cube.xml f7e3df0 

Diff: https://reviews.apache.org/r/47228/diff/


Testing
-------

Cube tests running fine and examples running fine.


Thanks,

Amareshwari Sriramadasu


Re: Review Request 47228: LENS-771 : Add test for multiple chain ref columns having subset chains

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47228/#review132846
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On May 11, 2016, 5:52 p.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47228/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 5:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-771
>     https://issues.apache.org/jira/browse/LENS-771
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added test for the issue and update example to have multiple chain ref columns.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java 4c98d86 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 51ba636 
>   lens-examples/src/main/resources/sales-cube.xml f7e3df0 
>   lens-examples/src/test/resources/yaml/sales-cube.yaml 2f5d7a7 
> 
> Diff: https://reviews.apache.org/r/47228/diff/
> 
> 
> Testing
> -------
> 
> Cube tests running fine and examples running fine.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 47228: LENS-771 : Add test for multiple chain ref columns having subset chains

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47228/
-----------------------------------------------------------

(Updated May 11, 2016, 12:22 p.m.)


Review request for lens.


Changes
-------

Updated example test


Bugs: LENS-771
    https://issues.apache.org/jira/browse/LENS-771


Repository: lens


Description
-------

Added test for the issue and update example to have multiple chain ref columns.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java 4c98d86 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 51ba636 
  lens-examples/src/main/resources/sales-cube.xml f7e3df0 
  lens-examples/src/test/resources/yaml/sales-cube.yaml 2f5d7a7 

Diff: https://reviews.apache.org/r/47228/diff/


Testing
-------

Cube tests running fine and examples running fine.


Thanks,

Amareshwari Sriramadasu