You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Chuckame (via GitHub)" <gi...@apache.org> on 2025/05/28 08:28:24 UTC

[PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

Chuckame opened a new pull request, #19837:
URL: https://github.com/apache/kafka/pull/19837

   This PR fixes a typo in the `RocksDBStore` where it currently uses a getter named `optimizeFiltersForHits`. However, to set the flag to true, we have to use `setOptimizeFiltersForHits(true)` instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #19837:
URL: https://github.com/apache/kafka/pull/19837#issuecomment-2964364758

   Oh dear. How embarrassing... Thanks for the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19837:
URL: https://github.com/apache/kafka/pull/19837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

Posted by "Chuckame (via GitHub)" <gi...@apache.org>.
Chuckame commented on PR #19837:
URL: https://github.com/apache/kafka/pull/19837#issuecomment-2920608377

   Nice catch also @chia7712, done. I did not find other uses of this `optimizeFiltersForHits` now 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org