You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/15 00:08:45 UTC
[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #22120: feature(ssh_tunnel): DAO Changes for SSH Tunnel
Antonio-RiveroMartnez opened a new pull request, #22120:
URL: https://github.com/apache/superset/pull/22120
### SUMMARY
- New DAO Class for SSH Tunnel
- Add method to fetch related ssh tunnel in the DatabaseDAO
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22120: feature(ssh_tunnel): DAO Changes for SSH Tunnel
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #22120:
URL: https://github.com/apache/superset/pull/22120#discussion_r1023064141
##########
superset/databases/dao.py:
##########
@@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]:
return dict(
charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states
)
+
+ @classmethod
+ def get_related_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]:
Review Comment:
Cool! Renamed to `get_ssh_tunnel` 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22120: feature(ssh_tunnel): DAO Changes for SSH Tunnel
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #22120:
URL: https://github.com/apache/superset/pull/22120#discussion_r1023108991
##########
superset/databases/dao.py:
##########
@@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]:
return dict(
charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states
)
+
+ @classmethod
+ def get_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]:
Review Comment:
Added :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #22120: feat(ssh_tunnel): DAO Changes for SSH Tunnel
Posted by GitBox <gi...@apache.org>.
hughhhh merged PR #22120:
URL: https://github.com/apache/superset/pull/22120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a diff in pull request #22120: feature(ssh_tunnel): DAO Changes for SSH Tunnel
Posted by GitBox <gi...@apache.org>.
hughhhh commented on code in PR #22120:
URL: https://github.com/apache/superset/pull/22120#discussion_r1023066884
##########
superset/databases/dao.py:
##########
@@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]:
return dict(
charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states
)
+
+ @classmethod
+ def get_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]:
Review Comment:
also can we write a small unit test for this here's an example
https://github.com/apache/superset/blob/89020b586687ecf84eef6d7337b6fea767162c9c/tests/unit_tests/datasets/dao/dao_tests.py#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a diff in pull request #22120: feature(ssh_tunnel): DAO Changes for SSH Tunnel
Posted by GitBox <gi...@apache.org>.
hughhhh commented on code in PR #22120:
URL: https://github.com/apache/superset/pull/22120#discussion_r1023060157
##########
superset/databases/dao.py:
##########
@@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]:
return dict(
charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states
)
+
+ @classmethod
+ def get_related_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]:
Review Comment:
let's just call the `get_ssh_tunnel` since it's a 1 to 1 relationship
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org