You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Rohith (JIRA)" <ji...@apache.org> on 2014/11/14 20:04:33 UTC

[jira] [Updated] (MAPREDUCE-6160) Potential NullPointerException in MRClientProtocol interface implementation.

     [ https://issues.apache.org/jira/browse/MAPREDUCE-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohith updated MAPREDUCE-6160:
------------------------------
    Attachment: MAPREDUCE-6160.patch

Attached the patch for handling NPE for invalid job id's. Please review.

> Potential NullPointerException in MRClientProtocol interface implementation.
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6160
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6160
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: MAPREDUCE-6160.patch
>
>
> In the implementation of MRClientProtocol, many methods can throw NullPointerExceptions. Instead of NullPointerExceptions, better to throw IOException with proper message.
> In the HistoryClientService class and MRClientService class has #verifyAndGetJob() method that return job object as null.
> {code}
> getTaskReport(GetTaskReportRequest request) throws IOException;
> getTaskAttemptReport(GetTaskAttemptReportRequest request) throws IOException;
> getCounters(GetCountersRequest request) throws IOException;
> getTaskAttemptCompletionEvents(GetTaskAttemptCompletionEventsRequest request) throws IOException;
> getTaskReports(GetTaskReportsRequest request) throws IOException;
> getDiagnostics(GetDiagnosticsRequest request) throws IOException;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)