You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Vadim Gritsenko <va...@verizon.net> on 2003/03/12 14:28:30 UTC
Re: cvs commit: cocoon-2.1/src/scratchpad/src/org/apache/cocoon/components/source/impl
blob.xconf
cziegeler@apache.org wrote:
>cziegeler 2003/03/12 01:35:39
>
>
> 1.2 +14 -15 cocoon-2.1/src/blocks/fop/java/org/apache/cocoon/serialization/FOPSerializer.java
>
>
...
> - // FIXME: How to do without URLFactory but relative to context?
> - urlFactory = (URLFactory)manager.lookup(URLFactory.ROLE);
> - URLFactorySourceResolver urlResolver = new URLFactorySourceResolver(urlFactory, manager);
> - configSource = urlResolver.resolve(configUrl);
> + resolver = (SourceResolver)this.manager.lookup(SourceResolver.ROLE);
> + configSource = resolver.resolveURI(configUrl);
>
Carsten,
AFAIU, you changed the behavior and now FOPSerializer will lookup config
not relative to the context, but relative to the current sitemap. If
that's what you want, then serializer docs also has to be changed (if
this was documented before...).
Vadim
Re: cvs commit: cocoon-2.1/src/scratchpad/src/org/apache/cocoon/components/source/impl
blob.xconf
Posted by Vadim Gritsenko <va...@verizon.net>.
Torsten Curdt wrote:
>>> AFAIU, you changed the behavior and now FOPSerializer will lookup
>>> config
>>> not relative to the context, but relative to the current sitemap. If
>>> that's what you want, then serializer docs also has to be changed (if
>>> this was documented before...).
>>>
>>
>> Argh, yes, that's true - if the former version used the context as
>> the base.
>> Hmm, I personally would like to search relative to the sitemap, so I
>> guess
>> updating the docs is the option.
>>
>> What do you think?
>
>
> Tend to aggree ..though this is a major change of behavior.
I don't have a preference; but this change should be mentioned in docs
and changes.xml.
Vadim
Re: cvs commit: cocoon-2.1/src/scratchpad/src/org/apache/cocoon/components/source/impl
blob.xconf
Posted by Torsten Curdt <tc...@dff.st>.
>>AFAIU, you changed the behavior and now FOPSerializer will lookup config
>>not relative to the context, but relative to the current sitemap. If
>>that's what you want, then serializer docs also has to be changed (if
>>this was documented before...).
>>
>
> Argh, yes, that's true - if the former version used the context as the base.
> Hmm, I personally would like to search relative to the sitemap, so I guess
> updating the docs is the option.
>
> What do you think?
Tend to aggree ..though this is a major change of behavior.
Ask on cocoon-users?
--
Torsten
RE: cvs commit: cocoon-2.1/src/scratchpad/src/org/apache/cocoon/components/source/impl blob.xconf
Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Vadim Gritsenko wrote:
> Carsten,
>
> AFAIU, you changed the behavior and now FOPSerializer will lookup config
> not relative to the context, but relative to the current sitemap. If
> that's what you want, then serializer docs also has to be changed (if
> this was documented before...).
>
Argh, yes, that's true - if the former version used the context as the base.
Hmm, I personally would like to search relative to the sitemap, so I guess
updating the docs is the option.
What do you think?
Carsten