[GitHub] [hudi] suryaprasanna commented on a change in pull request #4962: [HUDI-3355] Issue with out of order commits in the timeline when ingestion writers using SparkAllowUpdateStrategy

[GitBox <gi...@apache.org>]

suryaprasanna commented on a change in pull request #4962:
URL: https://github.com/apache/hudi/pull/4962#discussion_r826405634



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -120,6 +121,7 @@
   protected transient AsyncArchiveService asyncArchiveService;
   protected final TransactionManager txnManager;
   protected Option<Pair<HoodieInstant, Map<String, String>>> lastCompletedTxnAndMetadata = Option.empty();
+  protected List<HoodieInstant> pendingReplaceRequestedInstants = new ArrayList<>();

Review comment:
       Can the issue also occur for ingestion commits as well, not just for replacecommits?
   For example: 
   c1.commit
   c2.inflight
   c3.complete
   c4.requested(This is based out of c3 commit)
   Here lastCompletedTxnOwnerInstant will still be c3 and if c2 has a conflict with c4 it might cause an issue.
   
   While fetching from the getCandidateInstants method especially with findInstantsAfter, should we consider transition times for ordering the instants?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org