You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Thomas Andraschko <an...@gmail.com> on 2015/08/20 11:00:18 UTC

MyFaces Core Issue Tracker Cleanup

Hi,

i would invest some hours to do a big cleanup of our issue tracker.
There are tickets available which are 10 years old!
I think such a cleanup is really required. AFAIR mojarra did the same some
months ago.

I would do the following:

1) Close every issue older than 2010. The most issues still targets 1.x.
It's a litte bit hard to just close them but nobody will take care of them
in the future.
I would close them with a comment similiar like: Outdated, please reopen if
still interessted/required.

2) Close duplicate issues

3) Close improvements/enhancements tickets without a patch which targets
1.x - 2.1 (e.g. https://issues.apache.org/jira/browse/MYFACES-3402)

4) Close issues without feedback - same comment as 1)

5) Close issues which are untouched and feedback would be required - same
comment as 1) (e.g. https://issues.apache.org/jira/browse/MYFACES-3670)

Maybe each commiter could also go through his own tickets and close them if
not required anymore (e.g. like
https://issues.apache.org/jira/browse/MYFACES-2635 ?)

WDYT?

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
all right!
Added it:
http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-project-management.html

Will start with the first issues this week.

2015-08-26 20:05 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:

> I would say either
>
> http://myfaces.apache.org/wiki/core/faq.html
>
> or under
>
> http://myfaces.apache.org/wiki/core/committer-and-pmc-guide.html
>
> possibly at the bottom of the following page under "Issue Tracker
> guidelines"
>
>
> http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-developer-notes.html
>
> It seems like "MyFaces Project Management" would be the best place,
> but that page is empty.
>
>
> http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-project-management.html
>
>
> On Wed, Aug 26, 2015 at 1:38 PM, Thomas Andraschko
> <an...@gmail.com> wrote:
> > Would you add it as a FAQ item or a as a new page?
> >
> > 2015-08-21 17:23 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
> >>
> >> I don't know how they are used but they sound like they might fit what
> >> we want to do.
> >>
> >> On Fri, Aug 21, 2015 at 5:40 AM, Dennis Kieselhorst <ma...@dekies.de>
> >> wrote:
> >> >> We should probably document our policy of closing issues somewhere
> and
> >> >> refer that that policy in each comment.
> >> >>
> >> >> - Issues older than 5 years are closed.
> >> >> - Issues needing reporter feedback are closed after 1 year
> >> >> - Enhancement/improvement Issues without a patch for maintenance mode
> >> >> branches are closed.
> >> > There is also a "Pending Closed" and "Auto Closed" resolution. Does
> >> > anyone know how these are used by other projects?
> >
> >
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
I would say either

http://myfaces.apache.org/wiki/core/faq.html

or under

http://myfaces.apache.org/wiki/core/committer-and-pmc-guide.html

possibly at the bottom of the following page under "Issue Tracker guidelines"

http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-developer-notes.html

It seems like "MyFaces Project Management" would be the best place,
but that page is empty.

http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-project-management.html


On Wed, Aug 26, 2015 at 1:38 PM, Thomas Andraschko
<an...@gmail.com> wrote:
> Would you add it as a FAQ item or a as a new page?
>
> 2015-08-21 17:23 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
>>
>> I don't know how they are used but they sound like they might fit what
>> we want to do.
>>
>> On Fri, Aug 21, 2015 at 5:40 AM, Dennis Kieselhorst <ma...@dekies.de>
>> wrote:
>> >> We should probably document our policy of closing issues somewhere and
>> >> refer that that policy in each comment.
>> >>
>> >> - Issues older than 5 years are closed.
>> >> - Issues needing reporter feedback are closed after 1 year
>> >> - Enhancement/improvement Issues without a patch for maintenance mode
>> >> branches are closed.
>> > There is also a "Pending Closed" and "Auto Closed" resolution. Does
>> > anyone know how these are used by other projects?
>
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
Would you add it as a FAQ item or a as a new page?

2015-08-21 17:23 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:

> I don't know how they are used but they sound like they might fit what
> we want to do.
>
> On Fri, Aug 21, 2015 at 5:40 AM, Dennis Kieselhorst <ma...@dekies.de>
> wrote:
> >> We should probably document our policy of closing issues somewhere and
> >> refer that that policy in each comment.
> >>
> >> - Issues older than 5 years are closed.
> >> - Issues needing reporter feedback are closed after 1 year
> >> - Enhancement/improvement Issues without a patch for maintenance mode
> >> branches are closed.
> > There is also a "Pending Closed" and "Auto Closed" resolution. Does
> > anyone know how these are used by other projects?
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
I don't know how they are used but they sound like they might fit what
we want to do.

On Fri, Aug 21, 2015 at 5:40 AM, Dennis Kieselhorst <ma...@dekies.de> wrote:
>> We should probably document our policy of closing issues somewhere and
>> refer that that policy in each comment.
>>
>> - Issues older than 5 years are closed.
>> - Issues needing reporter feedback are closed after 1 year
>> - Enhancement/improvement Issues without a patch for maintenance mode
>> branches are closed.
> There is also a "Pending Closed" and "Auto Closed" resolution. Does
> anyone know how these are used by other projects?

Re: MyFaces Core Issue Tracker Cleanup

Posted by Dennis Kieselhorst <ma...@dekies.de>.
> We should probably document our policy of closing issues somewhere and
> refer that that policy in each comment.
>
> - Issues older than 5 years are closed.
> - Issues needing reporter feedback are closed after 1 year
> - Enhancement/improvement Issues without a patch for maintenance mode
> branches are closed.
There is also a "Pending Closed" and "Auto Closed" resolution. Does
anyone know how these are used by other projects?

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
Sure, let's start in the wiki.

It should probably be in a more permanent place, but there's a FAQ
item I have posted into issues already in the wiki somewhere, so
that's probably a good starting place for this one too.



On Fri, Aug 21, 2015 at 3:18 AM, Thomas Andraschko
<an...@gmail.com> wrote:
> sounds good!
> Probably in the wiki or somewhere?
>
> 2015-08-20 22:31 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
>>
>> We should probably document our policy of closing issues somewhere and
>> refer that that policy in each comment.
>>
>> - Issues older than 5 years are closed.
>> - Issues needing reporter feedback are closed after 1 year
>> - Enhancement/improvement Issues without a patch for maintenance mode
>> branches are closed.
>>
>> On Thu, Aug 20, 2015 at 4:15 PM, Thomas Andraschko
>> <an...@gmail.com> wrote:
>> > 4) i would probably close every ticket without feedback since 1 year.
>> >
>> > I will do 1-4 first, lets check 5) afterwards.
>> >
>> > Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :
>> >>
>> >> One more comment on 5).  I've found that if I specifically ask for a
>> >> patch that the reporter often submits one.  So I'd prefer we try that
>> >> approach first. In fact, we should get in the habit of doing so as
>> >> soon as we first read an issue to encourage reporters to become
>> >> involved in "scratching their own itch" and joining our community.
>> >>
>> >> On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mk...@gmail.com>
>> >> wrote:
>> >> > On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
>> >> > <an...@gmail.com> wrote:
>> >> >> 5) Close issues which are untouched and feedback would be required
>> >> >> 5) is a little bit difficult. I will take a look at them as last a
>> >> >> step
>> >> >> and
>> >> >> come back.
>> >> >
>> >> > Rather than closing these, I'd suggest we state that we need more
>> >> > feedback or a patch.
>
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
I could also post it in every issue, would be no problem :)



2015-08-21 9:18 GMT+02:00 Thomas Andraschko <an...@gmail.com>:

> sounds good!
> Probably in the wiki or somewhere?
>
> 2015-08-20 22:31 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
>
>> We should probably document our policy of closing issues somewhere and
>> refer that that policy in each comment.
>>
>> - Issues older than 5 years are closed.
>> - Issues needing reporter feedback are closed after 1 year
>> - Enhancement/improvement Issues without a patch for maintenance mode
>> branches are closed.
>>
>> On Thu, Aug 20, 2015 at 4:15 PM, Thomas Andraschko
>> <an...@gmail.com> wrote:
>> > 4) i would probably close every ticket without feedback since 1 year.
>> >
>> > I will do 1-4 first, lets check 5) afterwards.
>> >
>> > Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :
>> >>
>> >> One more comment on 5).  I've found that if I specifically ask for a
>> >> patch that the reporter often submits one.  So I'd prefer we try that
>> >> approach first. In fact, we should get in the habit of doing so as
>> >> soon as we first read an issue to encourage reporters to become
>> >> involved in "scratching their own itch" and joining our community.
>> >>
>> >> On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mkienenb@gmail.com
>> >
>> >> wrote:
>> >> > On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
>> >> > <an...@gmail.com> wrote:
>> >> >> 5) Close issues which are untouched and feedback would be required
>> >> >> 5) is a little bit difficult. I will take a look at them as last a
>> step
>> >> >> and
>> >> >> come back.
>> >> >
>> >> > Rather than closing these, I'd suggest we state that we need more
>> >> > feedback or a patch.
>>
>
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
sounds good!
Probably in the wiki or somewhere?

2015-08-20 22:31 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:

> We should probably document our policy of closing issues somewhere and
> refer that that policy in each comment.
>
> - Issues older than 5 years are closed.
> - Issues needing reporter feedback are closed after 1 year
> - Enhancement/improvement Issues without a patch for maintenance mode
> branches are closed.
>
> On Thu, Aug 20, 2015 at 4:15 PM, Thomas Andraschko
> <an...@gmail.com> wrote:
> > 4) i would probably close every ticket without feedback since 1 year.
> >
> > I will do 1-4 first, lets check 5) afterwards.
> >
> > Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :
> >>
> >> One more comment on 5).  I've found that if I specifically ask for a
> >> patch that the reporter often submits one.  So I'd prefer we try that
> >> approach first. In fact, we should get in the habit of doing so as
> >> soon as we first read an issue to encourage reporters to become
> >> involved in "scratching their own itch" and joining our community.
> >>
> >> On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mk...@gmail.com>
> >> wrote:
> >> > On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
> >> > <an...@gmail.com> wrote:
> >> >> 5) Close issues which are untouched and feedback would be required
> >> >> 5) is a little bit difficult. I will take a look at them as last a
> step
> >> >> and
> >> >> come back.
> >> >
> >> > Rather than closing these, I'd suggest we state that we need more
> >> > feedback or a patch.
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
We should probably document our policy of closing issues somewhere and
refer that that policy in each comment.

- Issues older than 5 years are closed.
- Issues needing reporter feedback are closed after 1 year
- Enhancement/improvement Issues without a patch for maintenance mode
branches are closed.

On Thu, Aug 20, 2015 at 4:15 PM, Thomas Andraschko
<an...@gmail.com> wrote:
> 4) i would probably close every ticket without feedback since 1 year.
>
> I will do 1-4 first, lets check 5) afterwards.
>
> Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :
>>
>> One more comment on 5).  I've found that if I specifically ask for a
>> patch that the reporter often submits one.  So I'd prefer we try that
>> approach first. In fact, we should get in the habit of doing so as
>> soon as we first read an issue to encourage reporters to become
>> involved in "scratching their own itch" and joining our community.
>>
>> On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mk...@gmail.com>
>> wrote:
>> > On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
>> > <an...@gmail.com> wrote:
>> >> 5) Close issues which are untouched and feedback would be required
>> >> 5) is a little bit difficult. I will take a look at them as last a step
>> >> and
>> >> come back.
>> >
>> > Rather than closing these, I'd suggest we state that we need more
>> > feedback or a patch.

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
4) i would probably close every ticket without feedback since 1 year.

I will do 1-4 first, lets check 5) afterwards.

Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :

> One more comment on 5).  I've found that if I specifically ask for a
> patch that the reporter often submits one.  So I'd prefer we try that
> approach first. In fact, we should get in the habit of doing so as
> soon as we first read an issue to encourage reporters to become
> involved in "scratching their own itch" and joining our community.
>
> On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mkienenb@gmail.com
> <javascript:;>> wrote:
> > On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
> > <andraschko.thomas@gmail.com <javascript:;>> wrote:
> >> 5) Close issues which are untouched and feedback would be required
> >> 5) is a little bit difficult. I will take a look at them as last a step
> and
> >> come back.
> >
> > Rather than closing these, I'd suggest we state that we need more
> > feedback or a patch.
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
One more comment on 5).  I've found that if I specifically ask for a
patch that the reporter often submits one.  So I'd prefer we try that
approach first. In fact, we should get in the habit of doing so as
soon as we first read an issue to encourage reporters to become
involved in "scratching their own itch" and joining our community.

On Thu, Aug 20, 2015 at 4:05 PM, Mike Kienenberger <mk...@gmail.com> wrote:
> On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
> <an...@gmail.com> wrote:
>> 5) Close issues which are untouched and feedback would be required
>> 5) is a little bit difficult. I will take a look at them as last a step and
>> come back.
>
> Rather than closing these, I'd suggest we state that we need more
> feedback or a patch.

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
On Thu, Aug 20, 2015 at 3:58 PM, Thomas Andraschko
<an...@gmail.com> wrote:
> 4) that would be issues where devs asked for more details and the creator
> didnt provided more details.

Yes, that seems reasonable, although we have to decide on a policy for
how long we should wait.


> 5) Close issues which are untouched and feedback would be required
> 5) is a little bit difficult. I will take a look at them as last a step and
> come back.

Rather than closing these, I'd suggest we state that we need more
feedback or a patch.

Re: MyFaces Core Issue Tracker Cleanup

Posted by Thomas Andraschko <an...@gmail.com>.
2) i think about something like "allow pluggable seralization mechansim", i
think thats enough to add such improvements to 2.2. i also use 2.1 and im
actually very happy with it.

4) that would be issues where devs asked for more details and the creator
didnt provided more details.

5) is a little bit difficult. I will take a look at them as last a step and
come back.

Am Donnerstag, 20. August 2015 schrieb Mike Kienenberger :

> Thanks for looking into this!
>
> Comments in line.
>
> On Thu, Aug 20, 2015 at 5:00 AM, Thomas Andraschko
> <andraschko.thomas@gmail.com <javascript:;>> wrote:
> > 3) Close improvements/enhancements tickets without a patch which targets
> 1.x - 2.1 (e.g. https://issues.apache.org/jira/browse/MYFACES-3402)
>
> MyFaces still supports 2.1.   My clients still use 2.1.   I'd say we
> should make it 1.x to 2.0.   But since it's only enhancements, I'm +0
> rather than -1.
>
> > 4) Close issues without feedback - same comment as 1)
> > 5) Close issues which are untouched and feedback would be required
> >      same comment as 1)
>
> I'm not certain that we should be doing this for 2.1 and 2.2 issues.
> I also don't understand the distinction between 4) and 5) so I may be
> misunderstanding your recommendation.
>
> > Maybe each committer could also go through his own tickets and close
> > them if not required any more
>
> Sounds good in theory, but I don't think most of our committers are
> active any longer.
>

Re: MyFaces Core Issue Tracker Cleanup

Posted by Mike Kienenberger <mk...@gmail.com>.
Thanks for looking into this!

Comments in line.

On Thu, Aug 20, 2015 at 5:00 AM, Thomas Andraschko
<an...@gmail.com> wrote:
> 3) Close improvements/enhancements tickets without a patch which targets 1.x - 2.1 (e.g. https://issues.apache.org/jira/browse/MYFACES-3402)

MyFaces still supports 2.1.   My clients still use 2.1.   I'd say we
should make it 1.x to 2.0.   But since it's only enhancements, I'm +0
rather than -1.

> 4) Close issues without feedback - same comment as 1)
> 5) Close issues which are untouched and feedback would be required
>      same comment as 1)

I'm not certain that we should be doing this for 2.1 and 2.2 issues.
I also don't understand the distinction between 4) and 5) so I may be
misunderstanding your recommendation.

> Maybe each committer could also go through his own tickets and close
> them if not required any more

Sounds good in theory, but I don't think most of our committers are
active any longer.

Re: MyFaces Core Issue Tracker Cleanup

Posted by Gerhard Petracek <ge...@gmail.com>.
+1

regards,
gerhard



2015-08-20 11:00 GMT+02:00 Thomas Andraschko <an...@gmail.com>:

> Hi,
>
> i would invest some hours to do a big cleanup of our issue tracker.
> There are tickets available which are 10 years old!
> I think such a cleanup is really required. AFAIR mojarra did the same some
> months ago.
>
> I would do the following:
>
> 1) Close every issue older than 2010. The most issues still targets 1.x.
> It's a litte bit hard to just close them but nobody will take care of them
> in the future.
> I would close them with a comment similiar like: Outdated, please reopen
> if still interessted/required.
>
> 2) Close duplicate issues
>
> 3) Close improvements/enhancements tickets without a patch which targets
> 1.x - 2.1 (e.g. https://issues.apache.org/jira/browse/MYFACES-3402)
>
> 4) Close issues without feedback - same comment as 1)
>
> 5) Close issues which are untouched and feedback would be required - same
> comment as 1) (e.g. https://issues.apache.org/jira/browse/MYFACES-3670)
>
> Maybe each commiter could also go through his own tickets and close them
> if not required anymore (e.g. like
> https://issues.apache.org/jira/browse/MYFACES-2635 ?)
>
> WDYT?
>
>