[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444131#comment-17444131 ] 

David Capwell commented on CASSANDRA-16310:
-------------------------------------------

bq. Having setters for max_top_size_partition_count and max_top_tombstone_partition_count suggests that we want to tweak it at runtime. However, the property consumers, TopPartitionTracker and ColumnFamilyStore do not update the value once initialized. So it has no effects when operator update the values.

org.apache.cassandra.metrics.TopPartitionTracker.Collector#Collector and org.apache.cassandra.metrics.TopPartitionTracker#merge.  So lets say you start up with max_top_tombstone_partition_count=10 and you really want 20 so set it via JMX, the next time we do repair we will populate 20 and will update the reference; so will take affect with the new configs.


bq. TopPartitionsTest only has the test cases for full repair. Can we add tests that run with preview repair? (I simply replaced the option in the nodetool commands in the tests.)

Going to try to help out with this patch, so will work on this test; just need to do IR + --validate

bq. The tests cases pass with the --preview option.

Will look into this

bq. They fail with the --validate option. No sstables are selected since the corresponding PreviewKind.REPAIRED filters out unrepaired ones.

Will look into this

bq. The todo comment at TableStatsPrinter line#131 can be removed, since it is implemented.

will look into this

bq. Nit: consider adding a isValidation() method to PreviewKind. So in ValidationManager#doValidation, we can have validator.getPreviewKind().isValidation(), instead of validator.getPreviewKind() == PreviewKind.REPAIRED, which is less readable.

will look into this

bq. Document the feature.

I will work on a NEWS entry and conf/cassandra.yaml

> Track top partitions (by size and tombstone count) and display in nodetool tablestats
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16310
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16310
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Other
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.x
>
>
> We should track the top partitions by size and tombstone count and display in {{nodetool tablestats}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org