You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gopidesupavan (via GitHub)" <gi...@apache.org> on 2025/04/17 10:35:07 UTC
[PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan opened a new pull request, #49396:
URL: https://github.com/apache/airflow/pull/49396
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #49396:
URL: https://github.com/apache/airflow/pull/49396#discussion_r2048764178
##########
providers/standard/tests/unit/standard/utils/test_sensor_helper.py:
##########
@@ -47,6 +47,8 @@
if TYPE_CHECKING:
from sqlalchemy.orm.session import Session
+pytestmark = pytest.mark.db_test
Review Comment:
Yeah mostly it is for AF2, am sure the tests will explode for some, i may need to fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #49396:
URL: https://github.com/apache/airflow/pull/49396#issuecomment-2812458818
alright this got missed 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #49396:
URL: https://github.com/apache/airflow/pull/49396#discussion_r2048877700
##########
providers/standard/tests/unit/standard/utils/test_sensor_helper.py:
##########
@@ -47,6 +47,8 @@
if TYPE_CHECKING:
from sqlalchemy.orm.session import Session
+pytestmark = pytest.mark.db_test
Review Comment:
Alright the `TestSensorHelper` is purely for AF2, its not required for AF3. in AF3 we used `task-instances/states` endpoint with task-sdk to fetch the task states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49396:
URL: https://github.com/apache/airflow/pull/49396#discussion_r2048757488
##########
providers/standard/tests/unit/standard/utils/test_sensor_helper.py:
##########
@@ -47,6 +47,8 @@
if TYPE_CHECKING:
from sqlalchemy.orm.session import Session
+pytestmark = pytest.mark.db_test
Review Comment:
We need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #49396:
URL: https://github.com/apache/airflow/pull/49396#discussion_r2048694180
##########
providers/standard/tests/unit/standard/utils/test_sensor_helper.py:
##########
@@ -42,7 +41,11 @@
from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
if AIRFLOW_V_3_0_PLUS:
+ from airflow.providers.standard.operators.empty import EmptyOperator
from airflow.utils.types import DagRunTriggeredByType
+else:
+ # TODO: Remove this import when we drop support for Airflow 2
+ from airflow.operators.empty import EmptyOperator # type: ignore[no-redef]
Review Comment:
standard provider is compatible with 2.9 which is the min Airflow version of providers
You can just import directly from provider without checking airflow version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #49396:
URL: https://github.com/apache/airflow/pull/49396#discussion_r2048706339
##########
providers/standard/tests/unit/standard/utils/test_sensor_helper.py:
##########
@@ -42,7 +41,11 @@
from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
if AIRFLOW_V_3_0_PLUS:
+ from airflow.providers.standard.operators.empty import EmptyOperator
from airflow.utils.types import DagRunTriggeredByType
+else:
+ # TODO: Remove this import when we drop support for Airflow 2
+ from airflow.operators.empty import EmptyOperator # type: ignore[no-redef]
Review Comment:
my bad yeah, confused :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #49396:
URL: https://github.com/apache/airflow/pull/49396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #49396:
URL: https://github.com/apache/airflow/pull/49396#issuecomment-2813650971
This is ready for review , one test failure which has already raised PR by Daniel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org