[GitHub] [spark] felixcheung commented on a change in pull request #24269: [SPARK-27341][CORE] fix a deadlock between TaskMemoryManager and UnsafeExternalSorter

[GitBox <gi...@apache.org>]

felixcheung commented on a change in pull request #24269: [SPARK-27341][CORE] fix a deadlock between TaskMemoryManager and UnsafeExternalSorter
URL: https://github.com/apache/spark/pull/24269#discussion_r271150191
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
 ##########
 @@ -573,19 +573,28 @@ public boolean hasNext() {
 
     @Override
     public void loadNext() throws IOException {
-      synchronized (this) {
 
 Review comment:
   is it possible lastPage != null on line 550 above when it is set? https://github.com/apache/spark/pull/24269/files#diff-027299fb14327ddcaba457f81ecff32cR550

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org