[GitHub] [incubator-doris] morningman commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r376700785
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -1682,7 +1683,11 @@ public long loadAlterJob(DataInputStream dis, long checksum, JobType type) throw
             newChecksum ^= size;
             for (int i = 0; i < size; i++) {
                 AlterJobV2 alterJobV2 = AlterJobV2.read(dis);
-                alterJobsV2.put(alterJobV2.getJobId(), alterJobV2);
+                if (type == JobType.ROLLUP) {
 
 Review comment:
   So.. Seem that this is a serious bug exist before?
   If yes, please add 
   
   `alterJobsV2 = this.getRollupHandler().getAlterJobsV2();` before.
   So here can be remain unchanged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org