[GitHub] [lucene-solr] HoustonPutman commented on issue #974: [SOLR-13865] Migrate replica routing code to SolrJ

[GitBox <gi...@apache.org>]

HoustonPutman commented on issue #974: [SOLR-13865] Migrate replica routing code to SolrJ
URL: https://github.com/apache/lucene-solr/pull/974#issuecomment-546400097
 
 
   Since @CaoManhDat  originally committed the `NodesSysPropsCacher` code, maybe he has an idea on how to replicate the same testing logic in SolrJ? I don't really want to migrate `TestInjection` to SolrJ, but at this point it seems like it may be cleanest option seeing as it only has one dependency in solr-core. In the meantime I've added a `CommonTestInjection` class in SolrJ that just does the logic for injecting `additionalProps`, but it would be awesome if we could keep the injection logic in just one class.
   
   And given how big this PR already is, I think it's probably better to keep the Streaming Expressions and SolrJ client integrations as a separate PR. That way they can get the discussion they deserve and not get overshadowed by this migration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org