You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/07 03:39:01 UTC
[GitHub] [skywalking] xuanyu66 opened a new pull request #6909: FIX: NPE when thrift field is nested
xuanyu66 opened a new pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
When thrift message has nested field, ServerInProtocolWrapper read Inner fieldStop and make context = null, then ServerInProtocolWrapper read outer fieldStop, which cause NPE.
So I move this logic to readMessageEnd() so that make sure it's invoked only once
```java
ServerInProtocolWrapper#readFieldBegin()
@Override
public TField readFieldBegin() throws TException {
................
if (field.type == TType.STOP) {
Boolean haveCreatedSpan =
(Boolean) ContextManager.getRuntimeContext().get(HAVE_CREATED_SPAN);
if (haveCreatedSpan != null && !haveCreatedSpan) {
try {
AbstractSpan span = ContextManager.createEntrySpan(
context.getOperatorName(), createContextCarrier(null));
span.start(context.startTime);
span.tag(TAG_ARGS, context.getArguments());
span.setComponent(ComponentsDefine.THRIFT_SERVER);
SpanLayer.asRPCFramework(span);
} catch (Throwable throwable) {
LOGGER.error("Failed to create EntrySpan.", throwable);
} finally {
context = null;
}
return field;
}
```
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `6.96%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 47.43% -6.97%
+ Complexity 4227 3622 -605
============================================
Files 1844 1009 -835
Lines 39358 25465 -13893
Branches 4360 2485 -1875
============================================
- Hits 21411 12079 -9332
+ Misses 16919 12331 -4588
- Partials 1028 1055 +27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `3.69%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 58.09% +3.69%
+ Complexity 4227 4208 -19
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14879 -6532
+ Misses 16919 9428 -7491
- Partials 1028 1304 +276
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1318 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `6.91%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 47.48% -6.92%
+ Complexity 4227 3626 -601
============================================
Files 1844 1009 -835
Lines 39358 25465 -13893
Branches 4360 2485 -1875
============================================
- Hits 21411 12093 -9318
+ Misses 16919 12319 -4600
- Partials 1028 1053 +25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5fcb54) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `20.98%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head a5fcb54 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 33.41% -20.99%
+ Complexity 4227 2033 -2194
=============================================
Files 1844 824 -1020
Lines 39358 20446 -18912
Branches 4360 1928 -2432
=============================================
- Hits 21411 6833 -14578
+ Misses 16919 13100 -3819
+ Partials 1028 513 -515
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1518 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `4.73%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 49.66% -4.74%
+ Complexity 4227 3748 -479
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12688 -8723
+ Misses 16919 11788 -5131
- Partials 1028 1071 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.03%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.36% -1.04%
+ Complexity 4227 3944 -283
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13651 -7760
+ Misses 16919 10750 -6169
- Partials 1028 1178 +150
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5fcb54) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `14.38%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head a5fcb54 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 40.01% -14.39%
+ Complexity 4227 2440 -1787
=============================================
Files 1844 824 -1020
Lines 39358 20674 -18684
Branches 4360 1976 -2384
=============================================
- Hits 21411 8272 -13139
+ Misses 16919 11740 -5179
+ Partials 1028 662 -366
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1490 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `3.74%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 58.14% +3.74%
+ Complexity 4227 4212 -15
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14892 -6519
+ Misses 16919 9415 -7504
- Partials 1028 1304 +276
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1317 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `2.30%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 52.09% -2.31%
+ Complexity 4227 3887 -340
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13325 -8086
+ Misses 16919 11108 -5811
- Partials 1028 1146 +118
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `2.62%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 51.77% -2.63%
+ Complexity 4227 3848 -379
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 13227 -8184
+ Misses 16919 11188 -5731
- Partials 1028 1132 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `5.60%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 48.80% -5.61%
+ Complexity 4227 3702 -525
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12467 -8944
+ Misses 16919 12043 -4876
- Partials 1028 1037 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.84%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.55% -0.85%
+ Complexity 4227 3951 -276
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13700 -7711
+ Misses 16919 10692 -6227
- Partials 1028 1187 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1334 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `3.38%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 51.01% -3.39%
+ Complexity 4227 3819 -408
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 13033 -8378
+ Misses 16919 11411 -5508
- Partials 1028 1103 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `1.05%`.
> The diff coverage is `8.94%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 55.46% +1.05%
+ Complexity 4227 4059 -168
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14204 -7207
+ Misses 16919 10162 -6757
- Partials 1028 1245 +217
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1326 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `11.31%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 43.08% -11.32%
+ Complexity 4227 2640 -1587
=============================================
Files 1844 825 -1019
Lines 39358 20768 -18590
Branches 4360 1983 -2377
=============================================
- Hits 21411 8947 -12464
+ Misses 16919 11104 -5815
+ Partials 1028 717 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1469 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `13.52%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 40.88% -13.53%
+ Complexity 4227 2515 -1712
=============================================
Files 1844 825 -1019
Lines 39358 20768 -18590
Branches 4360 1983 -2377
=============================================
- Hits 21411 8490 -12921
+ Misses 16919 11616 -5303
+ Partials 1028 662 -366
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `2.49%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 51.90% -2.50%
+ Complexity 4227 3852 -375
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 13260 -8151
+ Misses 16919 11145 -5774
- Partials 1028 1142 +114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `6.97%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 47.42% -6.98%
+ Complexity 4227 3621 -606
============================================
Files 1844 1009 -835
Lines 39358 25465 -13893
Branches 4360 2485 -1875
============================================
- Hits 21411 12076 -9335
+ Misses 16919 12332 -4587
- Partials 1028 1057 +29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `3.54%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 57.94% +3.54%
+ Complexity 4227 4204 -23
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14840 -6571
+ Misses 16919 9477 -7442
- Partials 1028 1294 +266
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1318 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `6.58%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 47.81% -6.59%
+ Complexity 4227 3637 -590
============================================
Files 1844 1009 -835
Lines 39358 25480 -13878
Branches 4360 2493 -1867
============================================
- Hits 21411 12183 -9228
+ Misses 16919 12300 -4619
+ Partials 1028 997 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1367 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `3.75%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 50.64% -3.76%
+ Complexity 4227 3800 -427
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12938 -8473
+ Misses 16919 11511 -5408
- Partials 1028 1098 +70
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `11.93%`.
> The diff coverage is `5.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 42.46% -11.94%
+ Complexity 4227 2699 -1528
=============================================
Files 1844 856 -988
Lines 39358 21674 -17684
Branches 4360 2075 -2285
=============================================
- Hits 21411 9203 -12208
+ Misses 16919 11780 -5139
+ Partials 1028 691 -337
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1455 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `8.23%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 46.16% -8.24%
+ Complexity 4227 3534 -693
============================================
Files 1844 1009 -835
Lines 39358 25465 -13893
Branches 4360 2485 -1875
============================================
- Hits 21411 11757 -9654
+ Misses 16919 12670 -4249
- Partials 1028 1038 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.34%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.05% -1.35%
+ Complexity 4227 3933 -294
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13572 -7839
+ Misses 16919 10847 -6072
- Partials 1028 1160 +132
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.42%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.97% -0.43%
+ Complexity 4227 3998 -229
============================================
Files 1844 1010 -834
Lines 39358 25575 -13783
Branches 4360 2500 -1860
============================================
- Hits 21411 13805 -7606
+ Misses 16919 10558 -6361
- Partials 1028 1212 +184
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `16.52%`.
> The diff coverage is `5.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 37.87% -16.53%
+ Complexity 4227 2323 -1904
=============================================
Files 1844 824 -1020
Lines 39358 20562 -18796
Branches 4360 1947 -2413
=============================================
- Hits 21411 7788 -13623
+ Misses 16919 12213 -4706
+ Partials 1028 561 -467
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1501 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.19%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.20% -1.20%
+ Complexity 4227 3969 -258
============================================
Files 1844 1010 -834
Lines 39358 25565 -13793
Branches 4360 2499 -1861
============================================
- Hits 21411 13601 -7810
+ Misses 16919 10773 -6146
- Partials 1028 1191 +163
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `5.36%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 49.03% -5.37%
+ Complexity 4227 3713 -514
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12528 -8883
+ Misses 16919 11973 -4946
- Partials 1028 1046 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `12.06%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 42.33% -12.07%
+ Complexity 4227 2709 -1518
=============================================
Files 1844 856 -988
Lines 39358 21692 -17666
Branches 4360 2076 -2284
=============================================
- Hits 21411 9183 -12228
+ Misses 16919 11777 -5142
+ Partials 1028 732 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1449 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `21.76%`.
> The diff coverage is `5.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 32.63% -21.77%
+ Complexity 4227 2022 -2205
=============================================
Files 1844 824 -1020
Lines 39358 20509 -18849
Branches 4360 1940 -2420
=============================================
- Hits 21411 6694 -14717
+ Misses 16919 13343 -3576
+ Partials 1028 472 -556
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1517 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `11.46%`.
> The diff coverage is `5.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 42.93% -11.47%
+ Complexity 4227 2734 -1493
=============================================
Files 1844 856 -988
Lines 39358 21674 -17684
Branches 4360 2075 -2285
=============================================
- Hits 21411 9306 -12105
+ Misses 16919 11669 -5250
+ Partials 1028 699 -329
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1445 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `4.74%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 49.65% -4.75%
+ Complexity 4227 3746 -481
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12685 -8726
+ Misses 16919 11791 -5128
- Partials 1028 1071 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `8.34%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 46.05% -8.35%
+ Complexity 4227 3531 -696
============================================
Files 1844 1009 -835
Lines 39358 25465 -13893
Branches 4360 2485 -1875
============================================
- Hits 21411 11728 -9683
+ Misses 16919 12708 -4211
- Partials 1028 1029 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `0.36%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 54.76% +0.36%
+ Complexity 4227 4051 -176
============================================
Files 1844 1010 -834
Lines 39358 25575 -13783
Branches 4360 2500 -1860
============================================
- Hits 21411 14007 -7404
+ Misses 16919 10335 -6584
- Partials 1028 1233 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1329 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `7.93%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 46.46% -7.94%
+ Complexity 4227 3541 -686
============================================
Files 1844 1009 -835
Lines 39358 25376 -13982
Branches 4360 2485 -1875
============================================
- Hits 21411 11790 -9621
+ Misses 16919 12606 -4313
+ Partials 1028 980 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `8.43%`.
> The diff coverage is `5.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 45.96% -8.44%
+ Complexity 4227 3517 -710
============================================
Files 1844 1009 -835
Lines 39358 25371 -13987
Branches 4360 2481 -1879
============================================
- Hits 21411 11662 -9749
+ Misses 16919 12728 -4191
+ Partials 1028 981 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `2.64%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 57.04% +2.64%
+ Complexity 4227 4167 -60
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14611 -6800
+ Misses 16919 9719 -7200
- Partials 1028 1281 +253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.36%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 54.03% -0.37%
+ Complexity 4227 3983 -244
============================================
Files 1844 1010 -834
Lines 39358 25601 -13757
Branches 4360 2500 -1860
============================================
- Hits 21411 13833 -7578
+ Misses 16919 10560 -6359
- Partials 1028 1208 +180
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `0.64%`.
> The diff coverage is `8.94%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 55.04% +0.64%
+ Complexity 4227 4024 -203
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14098 -7313
+ Misses 16919 10277 -6642
- Partials 1028 1236 +208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `3.58%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 50.81% -3.59%
+ Complexity 4227 3812 -415
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12981 -8430
+ Misses 16919 11466 -5453
- Partials 1028 1100 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.20%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.19% -1.21%
+ Complexity 4227 3968 -259
============================================
Files 1844 1010 -834
Lines 39358 25565 -13793
Branches 4360 2499 -1861
============================================
- Hits 21411 13600 -7811
+ Misses 16919 10774 -6145
- Partials 1028 1191 +163
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.23%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 54.16% -0.24%
+ Complexity 4227 3988 -239
============================================
Files 1844 1010 -834
Lines 39358 25601 -13757
Branches 4360 2500 -1860
============================================
- Hits 21411 13867 -7544
+ Misses 16919 10515 -6404
- Partials 1028 1219 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.10%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.29% -1.11%
+ Complexity 4227 3940 -287
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13632 -7779
+ Misses 16919 10769 -6150
- Partials 1028 1178 +150
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.23%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.16% -1.24%
+ Complexity 4227 3937 -290
============================================
Files 1844 1010 -834
Lines 39358 25579 -13779
Branches 4360 2499 -1861
============================================
- Hits 21411 13600 -7811
+ Misses 16919 10809 -6110
- Partials 1028 1170 +142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `3.41%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 50.98% -3.42%
+ Complexity 4227 3811 -416
============================================
Files 1844 1009 -835
Lines 39358 25531 -13827
Branches 4360 2495 -1865
============================================
- Hits 21411 13016 -8395
+ Misses 16919 11383 -5536
- Partials 1028 1132 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.17%`.
> The diff coverage is `5.69%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 54.22% -0.18%
+ Complexity 4227 3994 -233
============================================
Files 1844 1010 -834
Lines 39358 25601 -13757
Branches 4360 2500 -1860
============================================
- Hits 21411 13882 -7529
+ Misses 16919 10500 -6419
- Partials 1028 1219 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `1.05%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 53.35% -1.06%
+ Complexity 4227 3975 -252
============================================
Files 1844 1010 -834
Lines 39358 25565 -13793
Branches 4360 2499 -1861
============================================
- Hits 21411 13639 -7772
+ Misses 16919 10728 -6191
- Partials 1028 1198 +170
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `27.35%`.
> The diff coverage is `4.89%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 27.04% -27.36%
+ Complexity 4227 1732 -2495
=============================================
Files 1844 824 -1020
Lines 39358 20386 -18972
Branches 4360 1903 -2457
=============================================
- Hits 21411 5513 -15898
+ Misses 16919 14473 -2446
+ Partials 1028 400 -628
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1556 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `4.59%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 49.80% -4.60%
+ Complexity 4227 3762 -465
============================================
Files 1844 1010 -834
Lines 39358 25547 -13811
Branches 4360 2498 -1862
============================================
- Hits 21411 12724 -8687
+ Misses 16919 11744 -5175
- Partials 1028 1079 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1359 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `0.98%`.
> The diff coverage is `8.94%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 55.39% +0.98%
+ Complexity 4227 4049 -178
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14186 -7225
+ Misses 16919 10183 -6736
- Partials 1028 1242 +214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **increase** coverage by `2.80%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
+ Coverage 54.40% 57.20% +2.80%
+ Complexity 4227 4177 -50
============================================
Files 1844 1010 -834
Lines 39358 25611 -13747
Branches 4360 2501 -1859
============================================
- Hits 21411 14650 -6761
+ Misses 16919 9677 -7242
- Partials 1028 1284 +256
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1320 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `6.31%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 48.08% -6.32%
+ Complexity 4227 3661 -566
============================================
Files 1844 1010 -834
Lines 39358 25525 -13833
Branches 4360 2497 -1863
============================================
- Hits 21411 12273 -9138
+ Misses 16919 12243 -4676
+ Partials 1028 1009 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8847d78) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `13.51%`.
> The diff coverage is `5.71%`.
> :exclamation: Current head 8847d78 differs from pull request most recent head aa17b89. Consider uploading reports for the commit aa17b89 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
=============================================
- Coverage 54.40% 40.88% -13.52%
+ Complexity 4227 2516 -1711
=============================================
Files 1844 825 -1019
Lines 39358 20768 -18590
Branches 4360 1983 -2377
=============================================
- Hits 21411 8491 -12920
+ Misses 16919 11615 -5304
+ Partials 1028 662 -366
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6909: FIX: NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6909:
URL: https://github.com/apache/skywalking/pull/6909#issuecomment-834044287
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa17b89) into [master](https://codecov.io/gh/apache/skywalking/commit/49d36cb2f9148aadc83484bebcdf84e68328ee43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49d36cb) will **decrease** coverage by `0.31%`.
> The diff coverage is `8.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 54.40% 54.08% -0.32%
+ Complexity 4227 4003 -224
============================================
Files 1844 1010 -834
Lines 39358 25575 -13783
Branches 4360 2500 -1860
============================================
- Hits 21411 13833 -7578
+ Misses 16919 10523 -6396
- Partials 1028 1219 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `73.33% <0.00%> (-14.67%)` | `8.00 <1.00> (ø)` | |
| [...alking/oap/server/receiver/envoy/TCPOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvVENQT0FMRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...p/server/receiver/envoy/als/AccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0FjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <ø> (-49.10%)` | `0.00 <0.00> (ø)` | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.81%)` | `0.00 <0.00> (ø)` | |
| [...er/envoy/als/tcp/AbstractTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9BYnN0cmFjdFRDUEFjY2Vzc0xvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...iver/envoy/als/tcp/TCPLogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9UQ1BMb2dFbnRyeTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/6909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004eef6...aa17b89](https://codecov.io/gh/apache/skywalking/pull/6909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org