[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #219: Update scala dependencies

[GitBox <gi...@apache.org>]

mbeckerle commented on code in PR #219:
URL: https://github.com/apache/daffodil-vscode/pull/219#discussion_r918333182


##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -194,7 +194,7 @@ class DAPodil(
           case Left(errors) =>
             state.set(DAPodil.State.FailedToLaunch(request, errors, None)) *>
               Logger[IO].warn(show"error parsing launch args: ${errors.mkString_(", ")}") *> session
-              .sendResponse(request.respondFailure(Some(show"error parsing launch args: ${errors.mkString_(", ")}")))
+                .sendResponse(request.respondFailure(Some(show"error parsing launch args: ${errors.mkString_(", ")}")))

Review Comment:
   ditto. Revert just whitespace changes because they cause trouble trying to understand the version changes which is what this PR is about. 



##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -194,7 +194,7 @@ class DAPodil(
           case Left(errors) =>
             state.set(DAPodil.State.FailedToLaunch(request, errors, None)) *>
               Logger[IO].warn(show"error parsing launch args: ${errors.mkString_(", ")}") *> session
-              .sendResponse(request.respondFailure(Some(show"error parsing launch args: ${errors.mkString_(", ")}")))
+                .sendResponse(request.respondFailure(Some(show"error parsing launch args: ${errors.mkString_(", ")}")))

Review Comment:
   all the changes in this file appear to be just whitespace



##########
src/daffodilDebugger.ts:
##########
@@ -204,7 +204,8 @@ export async function getDebugger(
         name: artifact.scriptName,
         cwd: `${rootPath}/daffodil-debugger-${daffodilVersion}-${LIB_VERSION}/bin/`,
         hideFromUser: false,
-        shellPath: artifact.scriptName,
+        shellPath: '/bin/bash',

Review Comment:
   This seems to be a change separate from the updates of the dependencies? 



##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -84,8 +84,8 @@ object DAPSession {
       dispatcher.unsafeRunSync {
         for {
           _ <- Logger[IO].info(show"R> $request")
-          _ <- requests.offer(Some(request)).recoverWith {
-            case t => Logger[IO].error(t)(show"error during handling of request $request")
+          _ <- requests.offer(Some(request)).recoverWith { case t =>

Review Comment:
   If this is just a whitespace change, can we revert



##########
build.sbt:
##########
@@ -39,14 +39,13 @@ lazy val commonSettings = {
     ),
     licenses += ("Apache-2.0", new URL("https://www.apache.org/licenses/LICENSE-2.0.txt")),
     organization := "org.apache.daffodil",
-    scalaVersion := "2.12.15",
+    scalaVersion := "2.12.16",

Review Comment:
   I think we should not do this update. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org