You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/29 20:42:49 UTC
Review Request 42974: libprocess: Remove unused variable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
libprocess: Removed unused variable.
Diffs
-----
3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
Diff: https://reviews.apache.org/r/42974/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 42974: libprocess: Remove unused variable.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review117000
-----------------------------------------------------------
Ship it!
- Anand Mazumdar
On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 7:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> libprocess: Removed unused variable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
>
> Diff: https://reviews.apache.org/r/42974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42974: libprocess: Remove unused variable.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review116999
-----------------------------------------------------------
Bad patch!
Reviews applied: [42971]
Failed command: ./support/apply-review.sh -n -r 42971
Error:
...<truncated>...
2016-01-29 20:04:54 URL:https://reviews.apache.org/r/42971/diff/raw/ [633/633] -> "42971.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.
Full log: https://builds.apache.org/job/mesos-reviewbot/11124/console
- Mesos ReviewBot
On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 7:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> libprocess: Removed unused variable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
>
> Diff: https://reviews.apache.org/r/42974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42974: Removed unused variable in libprocess.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review117336
-----------------------------------------------------------
Bad patch!
Reviews applied: [42971, 42972]
Failed command: ./support/apply-review.sh -n -r 42972
Error:
2016-02-02 01:48:21 URL:https://reviews.apache.org/r/42972/diff/raw/ [728/728] -> "42972.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must not exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/11185/console
- Mesos ReviewBot
On Feb. 1, 2016, 10:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 10:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused variable in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
>
> Diff: https://reviews.apache.org/r/42974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42974: Removed unused variable in libprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review117418
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 1, 2016, 10:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 10:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused variable in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
>
> Diff: https://reviews.apache.org/r/42974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42974: Removed unused variable in libprocess.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 10:08 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fix commit message style
Summary (updated)
-----------------
Removed unused variable in libprocess.
Repository: mesos
Description (updated)
-------
Removed unused variable in libprocess.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437
Diff: https://reviews.apache.org/r/42974/diff/
Testing
-------
make check
Thanks,
Neil Conway