You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/03/24 20:46:56 UTC
[GitHub] [beam] damccorm commented on a diff in pull request #25610: [Playground] GetMetadata() endpoint
damccorm commented on code in PR #25610:
URL: https://github.com/apache/beam/pull/25610#discussion_r1148036035
##########
playground/backend/containers/go/build.gradle:
##########
@@ -83,19 +84,22 @@ task copyDockerfileDependencies(type: Copy) {
}
docker {
- name containerImageName(
- name: project.docker_image_default_repo_prefix + "playground-backend-go",
- root: project.rootProject.hasProperty(["docker-repository-root"]) ?
- project.rootProject["docker-repository-root"] :
- project.docker_image_default_repo_root)
- files "./build/"
- tags containerImageTags()
- buildArgs(['BASE_IMAGE': project.rootProject.hasProperty(["base-image"]) ?
- project.rootProject["base-image"] :
- "golang:1.18-bullseye",
- 'SDK_TAG': project.rootProject.hasProperty(["sdk-tag"]) ?
- project.rootProject["sdk-tag"] : project.rootProject.sdk_version,
- 'SDK_TAG_LOCAL': project.rootProject.sdk_version])
+ name containerImageName(
+ name: project.docker_image_default_repo_prefix + "playground-backend-go",
+ root: project.rootProject.hasProperty(["docker-repository-root"]) ?
+ project.rootProject["docker-repository-root"] :
+ project.docker_image_default_repo_root)
+ files "./build/"
+ tags containerImageTags()
+ buildArgs(
+ ['BASE_IMAGE' : project.rootProject.hasProperty(["base-image"]) ?
+ project.rootProject["base-image"] :
+ "golang:1.18-bullseye",
+ 'SDK_TAG' : project.rootProject.hasProperty(["sdk-tag"]) ?
+ project.rootProject["sdk-tag"] : project.rootProject.sdk_version,
+ 'SDK_TAG_LOCAL': project.rootProject.sdk_version,
+ 'GIT_COMMIT' : getGitCommitHash(),
+ 'GIT_TIMESTAMP': getGitCommitTimestamp()])
Review Comment:
IMO this is ok in order to get the reusability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org