You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/26 17:09:11 UTC
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13738
Change subject: Revert "IMPALA-7322: Add storage wait time to profile"
......................................................................
Revert "IMPALA-7322: Add storage wait time to profile"
This reverts commit 2fd795cf56e65a43087375867dcc9890e3a27330.
The test added has some issues:
* Fails with the local catalog enabled
* Is flaky if run concurrently with other tests that touch the same
tables.
Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/query_test/test_observability.py
7 files changed, 29 insertions(+), 131 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/13738/1
--
To view, visit http://gerrit.cloudera.org:8080/13738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 )
Change subject: Revert "IMPALA-7322: Add storage wait time to profile"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3755/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:48:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 )
Change subject: Revert "IMPALA-7322: Add storage wait time to profile"
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Will push through to unbreak precommit.
--
To view, visit http://gerrit.cloudera.org:8080/13738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:12:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13738 )
Change subject: Revert "IMPALA-7322: Add storage wait time to profile"
......................................................................
Revert "IMPALA-7322: Add storage wait time to profile"
This reverts commit 2fd795cf56e65a43087375867dcc9890e3a27330.
The test added has some issues:
* Fails with the local catalog enabled
* Is flaky if run concurrently with other tests that touch the same
tables.
Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Reviewed-on: http://gerrit.cloudera.org:8080/13738
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/query_test/test_observability.py
7 files changed, 29 insertions(+), 131 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 )
Change subject: Revert "IMPALA-7322: Add storage wait time to profile"
......................................................................
Patch Set 2:
I will fix the tests.
--
To view, visit http://gerrit.cloudera.org:8080/13738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:11:22 +0000
Gerrit-HasComments: No