You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Andrey Klochkov (JIRA)" <ji...@apache.org> on 2012/10/16 00:47:04 UTC

[jira] [Created] (HADOOP-8930) Cumulative code coverage calculation

Andrey Klochkov created HADOOP-8930:
---------------------------------------

             Summary: Cumulative code coverage calculation
                 Key: HADOOP-8930
                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
             Project: Hadoop Common
          Issue Type: Improvement
          Components: test
    Affects Versions: 2.0.2-alpha, 0.23.3
            Reporter: Andrey Klochkov
            Assignee: Andrey Klochkov


When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 

At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.

To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).

Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Andrey Klochkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Klochkov updated HADOOP-8930:
------------------------------------

    Attachment: HADOOP-8930.patch

Attaching a patch for 2.x/trunk
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Andrey Klochkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Klochkov updated HADOOP-8930:
------------------------------------

    Attachment: HADOOP-8930-branch-0.23.patch

Attaching a patch for 0.23
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478896#comment-13478896 ] 

Hudson commented on HADOOP-8930:
--------------------------------

Integrated in Hadoop-Yarn-trunk #7 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/7/])
    HADOOP-8930. Cumulative code coverage calculation (Andrey Klochkov via bobby) (Revision 1399426)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399426
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-project/pom.xml
* /hadoop/common/trunk/pom.xml

                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478987#comment-13478987 ] 

Hudson commented on HADOOP-8930:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1229 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1229/])
    HADOOP-8930. Cumulative code coverage calculation (Andrey Klochkov via bobby) (Revision 1399426)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399426
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-project/pom.xml
* /hadoop/common/trunk/pom.xml

                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477390#comment-13477390 ] 

Hadoop QA commented on HADOOP-8930:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12549388/HADOOP-8930.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1637//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1637//console

This message is automatically generated.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478970#comment-13478970 ] 

Hudson commented on HADOOP-8930:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1199 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1199/])
    HADOOP-8930. Cumulative code coverage calculation (Andrey Klochkov via bobby) (Revision 1399426)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399426
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-project/pom.xml
* /hadoop/common/trunk/pom.xml

                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Andrey Klochkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Klochkov updated HADOOP-8930:
------------------------------------

    Target Version/s: 2.0.3-alpha, 0.23.5  (was: 0.23.2, 2.0.3-alpha)
    
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477408#comment-13477408 ] 

Hadoop QA commented on HADOOP-8930:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12549394/HADOOP-8930-branch-0.23.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1638//console

This message is automatically generated.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478338#comment-13478338 ] 

Robert Joseph Evans commented on HADOOP-8930:
---------------------------------------------

The change looks fine to me, Clover seems to build and run at least as well as it did before.  I am +1 for the change.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Andrey Klochkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Klochkov updated HADOOP-8930:
------------------------------------

    Status: Patch Available  (was: Open)
    
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.2-alpha, 0.23.3
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Andrey Klochkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477412#comment-13477412 ] 

Andrey Klochkov commented on HADOOP-8930:
-----------------------------------------

Now new tests are needed as the patch updates build configuration only.
Also seems the robot doesn't apply non-trunk patches to a proper branch.  
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8930:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.5
                   2.0.3-alpha
                   3.0.0
           Status: Resolved  (was: Patch Available)

Thanks Andrey,

I pulled this into trunk, branch-2, and branch-0.23.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478955#comment-13478955 ] 

Hudson commented on HADOOP-8930:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #408 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/408/])
    HADOOP-8930. Cumulative code coverage calculation (Andrey Klochkov via bobby) (Revision 1399428)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399428
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
* /hadoop/common/branches/branch-0.23/pom.xml

                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8930) Cumulative code coverage calculation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478365#comment-13478365 ] 

Hudson commented on HADOOP-8930:
--------------------------------

Integrated in Hadoop-trunk-Commit #2883 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2883/])
    HADOOP-8930. Cumulative code coverage calculation (Andrey Klochkov via bobby) (Revision 1399426)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399426
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-project/pom.xml
* /hadoop/common/trunk/pom.xml

                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage gaps are caused by the way the coverage calculation is done currently. More specifically, right now coverage can not be calculated for the whole Core at once, but can only be calculated separately for top level modules like common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other modules of Core. For example, "org.apache.hadoop.fs" from hadoop-common-project/hadoop-common is not covered there but it's covered by tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move Clover profile definition up one level, from hadoop-project/pom.xml to the top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira