You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "SamWheating (via GitHub)" <gi...@apache.org> on 2023/08/22 18:08:27 UTC
[GitHub] [airflow] SamWheating opened a new pull request, #33622: Bind engine before attempting to drop archive tables
SamWheating opened a new pull request, #33622:
URL: https://github.com/apache/airflow/pull/33622
closes: https://github.com/apache/airflow/issues/33606
It looks like we weren't properly binding the engine to the table object before attempting to drop it, and as a result SQLalchemy was throwing exceptions. The only tests which actually run the db cleanup had set `skip_archive=False` so this went through undetected.
Anyways, added a test to replicate the issue and then fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33622: Bind engine before attempting to drop archive tables
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33622:
URL: https://github.com/apache/airflow/pull/33622#issuecomment-1689629013
Thanks @SamWheating !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33622: Bind engine before attempting to drop archive tables
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33622:
URL: https://github.com/apache/airflow/pull/33622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org