You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/07/22 01:17:22 UTC

Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61059/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7798
    https://issues.apache.org/jira/browse/MESOS-7798


Repository: mesos


Description
-------

Added --enable-lock-free-event-queue configuration in Mesos.


Diffs
-----

  configure.ac b2eeedab65d70718451cb8bbe556794b6d8e8db6 


Diff: https://reviews.apache.org/r/61059/diff/1/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61059/#review181399
-----------------------------------------------------------




configure.ac
Lines 151-154 (original), 151-159 (patched)
<https://reviews.apache.org/r/61059/#comment256931>

    Can you update docs/configuration.md to reflect these new configuration options?


- Benjamin Mahler


On July 22, 2017, 1:17 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61059/
> -----------------------------------------------------------
> 
> (Updated July 22, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
>     https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added --enable-lock-free-event-queue configuration in Mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac b2eeedab65d70718451cb8bbe556794b6d8e8db6 
> 
> 
> Diff: https://reviews.apache.org/r/61059/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61059/#review181296
-----------------------------------------------------------


Ship it!





configure.ac
Lines 151-154 (original), 151-159 (patched)
<https://reviews.apache.org/r/61059/#comment256822>

    Some TODOs to make the lock free queues the default configuration would be great


- Benjamin Mahler


On July 22, 2017, 1:17 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61059/
> -----------------------------------------------------------
> 
> (Updated July 22, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
>     https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added --enable-lock-free-event-queue configuration in Mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac b2eeedab65d70718451cb8bbe556794b6d8e8db6 
> 
> 
> Diff: https://reviews.apache.org/r/61059/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>