You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/19 05:09:07 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements

HyukjinKwon opened a new pull request, #42068:
URL: https://github.com/apache/spark/pull/42068

   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/42024 that removes unused variables and fix import statements (which should be the part of the whole refactoring).
   
   ### Why are the changes needed?
   
   To properly cleanup.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests should covoer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a diff in pull request #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42068:
URL: https://github.com/apache/spark/pull/42068#discussion_r1267616589


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/MapInBatchEvaluatorFactory.scala:
##########
@@ -85,8 +84,7 @@ class MapInBatchEvaluatorFactory(
           val flattenedBatch = new ColumnarBatch(outputVectors.toArray)
           flattenedBatch.setNumRows(batch.numRows())
           flattenedBatch.rowIterator.asScala
-        }
-        .map(unsafeProj)
+        }.map(unsafeProj)

Review Comment:
   since we are fixing the code style here, I think we can fix more
   ```
   columnarBatchIter.flatMap { batch =>
     ...
   }.map(unsafeProj)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42068:
URL: https://github.com/apache/spark/pull/42068#issuecomment-1641418278

   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42068:
URL: https://github.com/apache/spark/pull/42068#issuecomment-1641706328

   Merged to master and branch-3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42068: [SPARK-44361][SQL][FOLLOW-UP] Remove unused variables and fix import statements
URL: https://github.com/apache/spark/pull/42068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org