You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/10/20 17:05:51 UTC

[GitHub] brooklyn-server issue #386: Add AbstractInvokeEffectorPolicy

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/386
  
    Looks good. As well as the task-counter config comment, my only other comment is... should we add to the tests for `InvokeEffectorOnSensorChange` and `InvokeEffectorOnCollectionSensorChange`, that the busy-sensor is set?
    
    Except that highlights the absence of tests for `InvokeEffectorOnSensorChange`.
    
    I think this PR is fine without adding to the tests for `InvokeEffectorOnCollectionSensorChangeTest`, and should not be blocked adding tests for `InvokeEffectorOnSensorChange` (but we should add tests for that separately!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---