You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/06/13 08:18:45 UTC
[jira] Created: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Restructure the SVN repository after initial import
---------------------------------------------------
Key: ZOOKEEPER-45
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
Project: Zookeeper
Issue Type: Task
Components: build
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.0.0
SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
I intend to follow these steps:
1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
2) change the java package prefix from com.yahoo to org.apache
3) update the license headers in all source files
4) replace LICENSE file in root dir with Apache LICENSE file
5) add attribution NOTICE file to root dir
6) update the README file appropriately
7) create a new "src" directory in the zk root
8) move root "c" directory into src
9) move root "java" directory into src
10) create root "docs" directory
11) create src/docs directory
12) rename java/src to java/main
13) move root "test" directory to java/src/test
14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Attachment: add_timestamp_log4j.patch
add timestamp to log4j console output in order to help with test debugging on hudson.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608579#action_12608579 ]
Andrew Kornev commented on ZOOKEEPER-45:
----------------------------------------
BTW, this config here http://www.apache.org/dev/svn-eol-style.txt is missing an entry for *.cc which is a valid C++ extention.
*.cc = svn:eol-style=native
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Attachment: build_fixlog4j.patch
patch to fix log4j integration with tests.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609395#action_12609395 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
solaris and shell license patches have been committed to SVN.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch, ZOOKEEPER-45_shelllicense.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608996#action_12608996 ]
Hudson commented on ZOOKEEPER-45:
---------------------------------
Integrated in ZooKeeper-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/6/])
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608602#action_12608602 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
I have committed the two approved patches (log4j). These have address the logging issues on hudson.
However tests are still failing on asf hudson. This is being looked into (and logs w/timestamps should help).
I'm planning to close this issue once hudson is stable. (at that time if there are loose threads on this jira new jiras will be created for each). At that time I will also open svn for general committs not involved in the sf->asf migration.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607761#action_12607761 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
I've applied the changes specified in this jira (except for docs which I will do separately)
Please review the repository and let me know if you see issues. I verified that the code can be built (ant/eclipse) and that the tests all pass. If you see anything else let me know - Otw I'll declare SVN open to all committers and close the JIRA.
PS - be sure to follow the instructions here:
http://www.apache.org/dev/version-control.html#https-svn
In particular update your subversion config with
http://www.apache.org/dev/svn-eol-style.txt
I cleaned up eol as part of the migration from sf => apache but it would be nice going fwd if we didn't have to worry about this.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607811#action_12607811 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
1) we have Chagelog in java and in c. This is confusing. We should just have a top level Changelog unless we want to make two speerate releases for c client, java client and one for servers. Its better to release zookeeper as one package since if we have more than c/java bindings then it would be problematic making releases for all these clients.
not sure.. comments?
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-45) Restructure the SVN
repository after initial import
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608988#action_12608988 ]
fpj edited comment on ZOOKEEPER-45 at 6/28/08 2:10 AM:
--------------------------------------------------------------------------
It's not clear to me whether this patch works fine. The problem that I see is that under solaris the predicate:
((k.readyOps() & SelectionKey.OP_CONNECT) != 0)
will never be true, which means that we don't make the calls inside the if block. Now, you have added a line to change state to CONNECTED to the end of primeConnection, which is called in two places: startConnect() and run(). The one in startConnect is predicated by sock.connect(addr). As the channel is in non-blocking mode, the behavior of SocketChannel.connect() says that it may return false if connection is in progress. The call or run() may never happen either because of the problem Pat pointed out. The bottom line is that we again may never reach a connected state.
I wonder what is wrong with changing the predicate of the "if" block on run() to test also if state is not connected and sock is ready to read.
was (Author: fpj):
It's not clear to me weather this patch works fine. The problem that I see is that under solaris the predicate:
((k.readyOps() & SelectionKey.OP_CONNECT) != 0)
will never be true, which means that we don't make the calls inside the if block. Now, you have added a line to change state to CONNECTED to the end of primeConnection, which is called in two places: startConnect() and run(). The one in startConnect is predicated by sock.connect(addr). As the channel is in non-blocking mode, the behavior of SocketChannel.connect() says that it may return false if connection is in progress. The call or run() may never happen either because of the problem Pat pointed out. The bottom line is that we again may never reach a connected state.
I wonder what is wrong with changing the predicate of the "if" block on run() to test also if state is not connected and sock is ready to read.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608495#action_12608495 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-45:
-------------------------------------------------
+1, looks good to me
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-45:
-----------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604997#action_12604997 ]
Doug Cutting commented on ZOOKEEPER-45:
---------------------------------------
> do we want to create a zookeeper/site like in hadoop where the web pages are stored?
Yes. We can use the HBase site as a starting point.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608950#action_12608950 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
+1 for the solaris patch!
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604999#action_12604999 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
welcome to the world of zookeeper Doug :).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608598#action_12608598 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
Andrew, re your comment on changelog - that sounds reasonable but Apache requires that we provide a change log with each release of the project that details every feature added and bug resolved since the last release.
Looking at hadoop core I see that they have a large collection of src (incl c++) and contrib packages, but a single changes.txt at the toplevel.
http://svn.apache.org/repos/asf/hadoop/core/trunk/CHANGES.txt
More background: http://wiki.apache.org/hadoop/HowToContribute see "creating a patch" section.
I could see where we maintain multiple change log files and build a single toplevel changelog.txt during the release process but it wouldn't be as simple as cat'ing multiple files together (as the changes in each file are split into releases/sections).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605015#action_12605015 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
Yes, we will definitely have this directory. If you look on the svn site you'll see that the empty "site" already exists:
http://svn.apache.org/repos/asf/hadoop/zookeeper/
I didn't include setting up "site" in this jira issue as I had planned "site" as a step after setting up the docs src/docs directories under zookeeper/trunk (and will enter separate jira for that).
See hadoop's howtorelease wiki page for comprehensive detail on how things get published to the http servers for hadoop:
http://wiki.apache.org/hadoop/HowToRelease
(hbase uses the same process -- see their howtorelease page)
As to using hbase as a starting point it sounds like a good idea but I need to review the hbase/hadoop "site" before making any decisions (as I said I'll enter another jira for that once I make some progress on this one)
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Description:
SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
I intend to follow these steps:
1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
2) change the java package prefix from com.yahoo to org.apache
3) update the license headers in all source files
4) replace LICENSE file in root dir with Apache LICENSE file
5) add attribution NOTICE file to root dir
6) update the README file appropriately
7) create a new "src" directory in the zk root
8) move root "c" directory into src
9) move root "java" directory into src
10) create root "docs" directory
11) create src/docs directory
12) rename src/java/src to src/java/main
13) move root "test" directory to src/java/test
14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
was:
SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
I intend to follow these steps:
1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
2) change the java package prefix from com.yahoo to org.apache
3) update the license headers in all source files
4) replace LICENSE file in root dir with Apache LICENSE file
5) add attribution NOTICE file to root dir
6) update the README file appropriately
7) create a new "src" directory in the zk root
8) move root "c" directory into src
9) move root "java" directory into src
10) create root "docs" directory
11) create src/docs directory
12) rename java/src to java/main
13) move root "test" directory to java/test
14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608578#action_12608578 ]
Andrew Kornev commented on ZOOKEEPER-45:
----------------------------------------
To Mahadev, Pat and other hadoop admirers: I'd like to keep the changelogs for java, c and "other stuff that is not either c or java" in their respective subdirectories. The fact that all those components released in a single package should have no bearing on the location of a source file within the source hierarchy. Or, put in a different way, no one would seriously consider a proposal to move all of the c and java source files under the same directory just because they end up in the same release tar file.
Having said that, I support the idea of having a top level "CHANGES.txt" for changes that are not specific to any component (for example, addition of a new contributed component, creation of a new top level source dir, modification of sample config file, etc).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608215#action_12608215 ]
Patrick Hunt commented on ZOOKEEPER-45:
---------------------------------------
Re Mahadev comments 6/24: My comments:
1&2) Yes, we should move the changelog files from c/java up to the toplevel. At the same time change the name to "CHANGES.txt". See hadoop for their process: http://wiki.apache.org/hadoop/HowToRelease
3) no, I don't think we should change the name from src/java/main to src/java/core - zookeeper has a sibling sub-project in hadoop called "core" and such a change on our part might be confusing. Using "main" & "test" is fairly std, also adopted by Maven.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Description:
SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
I intend to follow these steps:
1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
2) change the java package prefix from com.yahoo to org.apache
3) update the license headers in all source files
4) replace LICENSE file in root dir with Apache LICENSE file
5) add attribution NOTICE file to root dir
6) update the README file appropriately
7) create a new "src" directory in the zk root
8) move root "c" directory into src
9) move root "java" directory into src
10) create root "docs" directory
11) create src/docs directory
12) rename java/src to java/main
13) move root "test" directory to java/test
14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
was:
SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
I intend to follow these steps:
1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
2) change the java package prefix from com.yahoo to org.apache
3) update the license headers in all source files
4) replace LICENSE file in root dir with Apache LICENSE file
5) add attribution NOTICE file to root dir
6) update the README file appropriately
7) create a new "src" directory in the zk root
8) move root "c" directory into src
9) move root "java" directory into src
10) create root "docs" directory
11) create src/docs directory
12) rename java/src to java/main
13) move root "test" directory to java/src/test
14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename java/src to java/main
> 13) move root "test" directory to java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608988#action_12608988 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-45:
-------------------------------------------------
It's not clear to me weather this patch works fine. The problem that I see is that under solaris the predicate:
((k.readyOps() & SelectionKey.OP_CONNECT) != 0)
will never be true, which means that we don't make the calls inside the if block. Now, you have added a line to change state to CONNECTED to the end of primeConnection, which is called in two places: startConnect() and run(). The one in startConnect is predicated by sock.connect(addr). As the channel is in non-blocking mode, the behavior of SocketChannel.connect() says that it may return false if connection is in progress. The call or run() may never happen either because of the problem Pat pointed out. The bottom line is that we again may never reach a connected state.
I wonder what is wrong with changing the predicate of the "if" block on run() to test also if state is not connected and sock is ready to read.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Attachment: fix_solaris_tests.patch
There is an issue on solaris where OP_CONNECT is not triggered for new non-blocking sockets connecting on loopback interface. On wind/linux this is not seen, happens only on solaris, see the following for more background:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6288599
Our code was basically handling this, however the state change to "connected' should have been in primeconnection, not in run method (was missing for startconnection).
This patch fixes the problem by moving the state change into primeconnection, handling all connect paths. I verified this fix by running the tests before/after on solaris and linux machines.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Attachment: ZOOKEEPER-45_shelllicense.patch
Adds license header to shell scripts.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch, ZOOKEEPER-45_shelllicense.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609394#action_12609394 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
+1 on the patch for adding headers to shell scripts.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch, ZOOKEEPER-45_shelllicense.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607814#action_12607814 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
2) we anyway need a top level changelog for other stuff that is not either c or java.
3) workspace/zookeeper_apache/src/java/main
can we use some other name other than main..
i like core?
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604996#action_12604996 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
do we want to create a zookeeper/site like in hadoop where the web pages are stored?
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-45) Restructure the SVN repository after
initial import
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-45:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Closing this issue: SVN is now setup with proper structure and Hudson is also running as part of it's CI loop.
All attached patches have been reviewed and committed to SVN.
I added ZOOKEEPER-70 & ZOOKEEPER-71 to JIRA to track a few loose ends (docs & changelog).
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch, fix_solaris_tests.patch, ZOOKEEPER-45_shelllicense.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository
after initial import
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608199#action_12608199 ]
Mahadev konar commented on ZOOKEEPER-45:
----------------------------------------
+1 for the patch.
> Restructure the SVN repository after initial import
> ---------------------------------------------------
>
> Key: ZOOKEEPER-45
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45
> Project: Zookeeper
> Issue Type: Task
> Components: build
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: build_fixlog4j.patch
>
>
> SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following:
> I intend to follow these steps:
> 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk)
> 2) change the java package prefix from com.yahoo to org.apache
> 3) update the license headers in all source files
> 4) replace LICENSE file in root dir with Apache LICENSE file
> 5) add attribution NOTICE file to root dir
> 6) update the README file appropriately
> 7) create a new "src" directory in the zk root
> 8) move root "c" directory into src
> 9) move root "java" directory into src
> 10) create root "docs" directory
> 11) create src/docs directory
> 12) rename src/java/src to src/java/main
> 13) move root "test" directory to src/java/test
> 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation).
> steps 10&11 are required for zk documentation storage. src/docs is the location of all documentation in "forrest xml" format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors.
> I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this "script" is the documentation of what will be changed (comments added for any deviation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.