[GitHub] [incubator-druid] gianm commented on a change in pull request #7579: Adjust required permissions for system schema

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7579: Adjust required permissions for system schema
URL: https://github.com/apache/incubator-druid/pull/7579#discussion_r279998767
 
 

 ##########
 File path: docs/content/development/extensions-core/druid-basic-security.md
 ##########
 @@ -310,6 +310,18 @@ For information on what HTTP methods are supported on a particular request endpo
 
 GET requires READ permission, while POST and DELETE require WRITE permission.
 
+### SQL Permissions
+
+Queries on Druid datasources require DATASOURCE READ permissions for the specified datasource.
+
+Queries on the [information schema tables](../../querying/sql.html#information-schema) require DATASOURCE READ access for the specified datasource.
 
 Review comment:
   Please adjust the language a bit- there is not necessarily any 'specified datasource' with the information schema. The query might just be `SELECT * FROM INFORMATION_SCHEMA.COLUMNS`. I'd suggest:
   
   ```
   Queries on the [INFORMATION_SCHEMA tables](../../querying/sql.html#information-schema) will
   return information about datasources that the caller has DATASOURCE READ access to. Other
   datasources will be omitted.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org