[GitHub] [kafka] showuon commented on a diff in pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits

[GitBox <gi...@apache.org>]

showuon commented on code in PR #12626:
URL: https://github.com/apache/kafka/pull/12626#discussion_r969036313


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java:
##########
@@ -211,8 +211,23 @@ public void poll(RequestFuture<?> future) {
      * @throws InterruptException if the calling thread is interrupted
      */
     public boolean poll(RequestFuture<?> future, Timer timer) {
+        return poll(future, timer, false);
+    }
+
+    /**
+     * Block until the provided request future request has finished or the timeout has expired.
+     *
+     * @param future The request future to wait for
+     * @param timer Timer bounding how long this method can block
+     * @param disableWakeup true if we should not check for wakeups, false otherwise
+     *
+     * @return true if the future is done, false otherwise
+     * @throws WakeupException if {@link #wakeup()} is called from another thread

Review Comment:
   We should mention `WakeupException` only throws when `disableWakeup` is false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org