You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "heguanhui (via GitHub)" <gi...@apache.org> on 2026/05/28 11:18:12 UTC
[PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
heguanhui opened a new pull request, #63843:
URL: https://github.com/apache/doris/pull/63843
### What problem does this PR solve?
Issue Number: close #63728
Problem Summary: FE depends on JDK 17 for compilation (parent pom set `maven.compiler.source/target=17` since PR #62221), but fe-core's `maven-compiler-plugin` still had `<release>8</release>` as a leftover from PR #41417. This caused FE unit tests using JDK 17 APIs (e.g., `Random.nextLong(long)`) to fail at compile time. Additionally, `PatternDescribableProcessor` declared `@SupportedSourceVersion(SourceVersion.RELEASE_8)`, which is inconsistent with the JDK 17 compilation target.
### Release note
None
### Check List (For Author)
- Test: Manual test (compilation passes with JDK 17)
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563892945
<details>
<summary>TPC-H: <b>Total hot run time: 31441 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17613 4040 3992 3992
q2 q3 10757 1408 791 791
q4 4684 471 339 339
q5 7606 2276 2085 2085
q6 241 183 136 136
q7 935 772 625 625
q8 9378 1744 1523 1523
q9 5242 4967 4954 4954
q10 6389 2197 1844 1844
q11 436 268 244 244
q12 630 413 284 284
q13 18221 3380 2795 2795
q14 269 258 234 234
q15 q16 816 772 704 704
q17 1000 966 992 966
q18 7137 5771 5563 5563
q19 1322 1302 1057 1057
q20 681 434 276 276
q21 6476 2882 2653 2653
q22 445 389 376 376
Total cold run time: 100278 ms
Total hot run time: 31441 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4914 4643 4635 4635
q2 q3 4874 5258 4780 4780
q4 2114 2194 1381 1381
q5 4809 4861 4740 4740
q6 229 173 128 128
q7 1847 1815 1561 1561
q8 2399 2102 2062 2062
q9 7896 7792 7488 7488
q10 4995 4714 4257 4257
q11 531 387 357 357
q12 722 743 520 520
q13 3027 3398 2795 2795
q14 271 280 250 250
q15 q16 676 703 619 619
q17 1293 1262 1245 1245
q18 7262 6832 6852 6832
q19 1126 1127 1096 1096
q20 2210 2204 1960 1960
q21 5303 4528 4440 4440
q22 515 445 427 427
Total cold run time: 57013 ms
Total hot run time: 51573 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4564885963
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/32)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63843_3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63843_3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563538971
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4599163917
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #63843:
URL: https://github.com/apache/doris/pull/63843#discussion_r3392812158
##########
fe/fe-core/pom.xml:
##########
@@ -854,7 +854,7 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <release>8</release>
+ <release>17</release>
</configuration>
Review Comment:
Deleting this line would be better; we should manage versions uniformly in the parent pom file to maintain consistency.
Submodules only need to explicitly declare overridden functions when necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #63843:
URL: https://github.com/apache/doris/pull/63843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563623880
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563624231
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4564126350
# FE UT Coverage Report
Increment line coverage ` 100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63843_3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63843_3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563473183
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Update fe-core compiler release level from 8 to 17 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63843:
URL: https://github.com/apache/doris/pull/63843#issuecomment-4563975551
<details>
<summary>TPC-DS: <b>Total hot run time: 170696 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3f6f1594ff4cf4d5e473d10c415dc2d99b605ff4, data reload: false
query5 4324 674 519 519
query6 325 217 186 186
query7 4339 561 312 312
query8 321 227 223 223
query9 8785 4149 4122 4122
query10 442 342 292 292
query11 5786 2592 2233 2233
query12 182 130 123 123
query13 1290 640 411 411
query14 6151 5498 5198 5198
query14_1 4514 4814 4435 4435
query15 219 203 180 180
query16 1008 417 408 408
query17 1116 717 581 581
query18 2684 486 338 338
query19 214 204 160 160
query20 137 130 126 126
query21 213 139 112 112
query22 13739 13589 13391 13391
query23 17335 16521 16105 16105
query23_1 16366 16358 16269 16269
query24 7425 1791 1304 1304
query24_1 1332 1323 1342 1323
query25 534 469 410 410
query26 1332 343 174 174
query27 2647 568 347 347
query28 4383 2068 2027 2027
query29 957 610 500 500
query30 301 236 198 198
query31 1134 1068 951 951
query32 87 75 73 73
query33 547 366 291 291
query34 1237 1180 667 667
query35 782 804 689 689
query36 1404 1412 1251 1251
query37 153 100 87 87
query38 3217 3154 3078 3078
query39 924 913 884 884
query39_1 885 887 898 887
query40 223 149 122 122
query41 66 61 61 61
query42 108 112 111 111
query43 339 340 292 292
query44
query45 210 203 193 193
query46 1095 1211 717 717
query47 2342 2312 2269 2269
query48 371 418 298 298
query49 623 487 374 374
query50 1032 350 252 252
query51 4309 4327 4203 4203
query52 103 106 99 99
query53 259 282 199 199
query54 309 266 243 243
query55 92 90 85 85
query56 289 301 301 301
query57 1436 1388 1320 1320
query58 293 270 256 256
query59 1601 1674 1462 1462
query60 317 314 307 307
query61 169 161 172 161
query62 700 652 589 589
query63 251 201 210 201
query64 2422 808 657 657
query65
query66 1697 484 355 355
query67 29752 28974 29547 28974
query68
query69 482 333 303 303
query70 1058 1029 1038 1029
query71 305 276 268 268
query72 2885 2637 2358 2358
query73 858 795 430 430
query74 5118 4922 4767 4767
query75 2695 2599 2262 2262
query76 2296 1180 814 814
query77 406 419 330 330
query78 12422 12333 11856 11856
query79 1261 1046 764 764
query80 591 571 485 485
query81 451 284 250 250
query82 248 163 126 126
query83 280 283 254 254
query84 262 152 116 116
query85 903 581 509 509
query86 370 334 324 324
query87 3450 3366 3271 3271
query88 3666 2743 2717 2717
query89 443 406 352 352
query90 2173 196 192 192
query91 190 177 146 146
query92 81 80 78 78
query93 1431 1453 875 875
query94 540 393 322 322
query95 682 383 347 347
query96 1099 759 317 317
query97 2722 2721 2604 2604
query98 239 230 229 229
query99 1200 1177 1027 1027
Total cold run time: 252794 ms
Total hot run time: 170696 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org