You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Першин Юрий Петрович <pe...@prosoftsystems.ru> on 2012/10/14 12:40:50 UTC
patch for missed mods problem
Hi,
Please look at the patch for
https://svn.apache.org/repos/asf/subversion/tags/1.7.7/subversion/svn/log-cmd.c (trunk-applicable)
BR, UrSoft
Re: patch for missed mods problem
Posted by Julian Foad <ju...@btopenworld.com>.
Першин Юрий Петрович <pe...@prosoftsystems.ru> wrote:
> Please look at the patch for
>
>https://svn.apache.org/repos/asf/subversion/tags/1.7.7/subversion/svn/log-cmd.c (trunk-applicable)
Thank you, Pershin. I have committed this in r1398100, so it should be available in release 1.8.
I see that the feature was introduced in 1.7.0. We could also back-port the fix to the next 1.7.x release.
An explanation for everybody else here. When 'prop-mods' and 'text-mods' flags were added to the 'log' functionality in r877688 (May 2009), they were supposedly included in 'log -v --xml' output but in fact only when copy-from info is present: see the diff <http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/log-cmd.c?r1=877688&r2=877687&pathrev=877688&diff_format=l>.
This patch makes 'prop-mods' and 'text-mods' flags available in 'svn log -v --xml' output for all modified nodes, as was originally intended. For example, using trunk without this patch:
[[[
$ svn log --xml -qv -r1389302
[...]
<path
kind="file"
action="M">/subversion/trunk/build.conf</path>
<path
kind="dir"
action="D">/subversion/trunk/tools/fsfs</path>
<path
prop-mods="false"
text-mods="false"
kind="file"
copyfrom-path="/subversion/trunk/tools/fsfs/reorg.c"
copyfrom-rev="1387987"
action="A">/subversion/trunk/tools/server-side/fsfs-reorg.c</path>
[...]
]]]
and with the patch:
[[[
$ svn log --xml -qv -r1389302
[...]
<path
prop-mods="false"
text-mods="true"
kind="file"
action="M">/subversion/trunk/build.conf</path>
<path
prop-mods="false"
text-mods="false"
kind="dir"
action="D">/subversion/trunk/tools/fsfs</path>
<path
prop-mods="false"
text-mods="false"
kind="file"
copyfrom-path="/subversion/trunk/tools/fsfs/reorg.c"
copyfrom-rev="1387987"
action="A">/subversion/trunk/tools/server-side/fsfs-reorg.c</path>
[...]
]]]
- Julian