You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/20 22:11:05 UTC
[GitHub] [spark] maryannxue opened a new pull request #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
maryannxue opened a new pull request #28275:
URL: https://github.com/apache/spark/pull/28275
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR makes sure that AQE does not call update UI if the current execution ID does not match the current query.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Without this fix, there could be a potential deadlock.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616995211
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
maryannxue commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616839455
cc @cloud-fan @Ngone51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616995211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616918482
**[Test build #121556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121556/testReport)** for PR 28275 at commit [`e08883c`](https://github.com/apache/spark/commit/e08883ce56e744d9908123ea9f895ec0475a0766).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on a change in pull request #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
maryannxue commented on a change in pull request #28275:
URL: https://github.com/apache/spark/pull/28275#discussion_r411726964
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -274,18 +275,17 @@ object QueryExecution {
* are correct, insert whole stage code gen, and try to reduce the work done by reusing exchanges
* and subqueries.
*/
- private[execution] def preparations(sparkSession: SparkSession): Seq[Rule[SparkPlan]] = {
-
- val sparkSessionWithAqeOff = getOrCloneSessionWithAqeOff(sparkSession)
-
+ private[execution] def preparations(
+ sparkSession: SparkSession,
+ adaptiveExecutionRule: Option[InsertAdaptiveSparkPlan] = None): Seq[Rule[SparkPlan]] = {
+ // `AdaptiveSparkPlanExec` is a leaf node. If inserted, all the following rules will be no-op
+ // as the original plan is hidden behind `AdaptiveSparkPlanExec`.
+ adaptiveExecutionRule.toSeq ++
Seq(
- // `AdaptiveSparkPlanExec` is a leaf node. If inserted, all the following rules will be no-op
- // as the original plan is hidden behind `AdaptiveSparkPlanExec`.
- InsertAdaptiveSparkPlan(AdaptiveExecutionContext(sparkSession)),
// If the following rules apply, it means the main query is not AQE-ed, so we make sure the
// subqueries are not AQE-ed either.
- PlanDynamicPruningFilters(sparkSessionWithAqeOff),
Review comment:
We do not need to turn off AQE here, as those rules will call `prepareExecutedPlan` without an `adaptiveExecutionRule`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616918789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616994796
**[Test build #121556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121556/testReport)** for PR 28275 at commit [`e08883c`](https://github.com/apache/spark/commit/e08883ce56e744d9908123ea9f895ec0475a0766).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class CacheManager extends Logging with AdaptiveSparkPlanHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616839553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616995222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121556/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616925607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616925607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616839097
**[Test build #121548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121548/testReport)** for PR 28275 at commit [`7061660`](https://github.com/apache/spark/commit/706166009627afbdbf213c3dcad64196b5f0acff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616839553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616918789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616918482
**[Test build #121556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121556/testReport)** for PR 28275 at commit [`e08883c`](https://github.com/apache/spark/commit/e08883ce56e744d9908123ea9f895ec0475a0766).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616924920
**[Test build #121548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121548/testReport)** for PR 28275 at commit [`7061660`](https://github.com/apache/spark/commit/706166009627afbdbf213c3dcad64196b5f0acff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class AdaptiveExecutionContext(session: SparkSession, qe: QueryExecution) `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616839097
**[Test build #121548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121548/testReport)** for PR 28275 at commit [`7061660`](https://github.com/apache/spark/commit/706166009627afbdbf213c3dcad64196b5f0acff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28275: [SPARK-31501][SQL] AQE update UI should not cause deadlock
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616936535
good catch! merging to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org