[GitHub] [kafka] divijvaidya commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1300024562


##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -370,6 +384,10 @@ public long remoteLogIndexFileCacheTotalSizeBytes() {
         return remoteLogIndexFileCacheTotalSizeBytes;
     }
 
+    public long getRemoteLogIndexFileCacheTotalSize() {

Review Comment:
   In Kafka code base we don't use prefix such as "get" for getters. You can rename this to `remoteLogIndexFileCacheTotalSize()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org