[GitHub] [trafficserver] bneradt commented on a diff in pull request #9132: Fail sni.yaml loading if related resources fail to load

[GitBox <gi...@apache.org>]

bneradt commented on code in PR #9132:
URL: https://github.com/apache/trafficserver/pull/9132#discussion_r991694323


##########
iocore/net/SSLSNIConfig.h:
##########
@@ -100,7 +100,7 @@ class SNIConfig
   using scoped_config = ConfigProcessor::scoped_config<SNIConfig, SNIConfigParams>;
 
   static void startup();
-  static void reconfigure();
+  static int reconfigure();

Review Comment:
   A doxygen comment could be helpful, especially explaining the @return meaning.



##########
iocore/net/SSLSNIConfig.h:
##########
@@ -86,7 +86,7 @@ struct SNIConfigParams : public ConfigInfo {
 
   const NextHopProperty *get_property_config(const std::string &servername) const;
   int initialize();
-  void load_sni_config();
+  int load_sni_config();

Review Comment:
   A doxygen comment could be helpful, especially explaining the @return meaning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org