You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/06 06:46:22 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2830: Add NaN handling in dyn scalar comparison kernels

viirya commented on code in PR #2830:
URL: https://github.com/apache/arrow-rs/pull/2830#discussion_r988609227


##########
arrow/src/datatypes/native.rs:
##########
@@ -46,6 +46,7 @@ pub(crate) mod native_op {
         + Div<Output = Self>
         + Rem<Output = Self>
         + Zero
+        + num::ToPrimitive

Review Comment:
   Because kernels like `eq_dyn_scalar` have this type binding. In macro `dyn_compare_scalar`, `ToPrimitive` api is used on the input scalar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org