[GitHub] [flink] dawidwys opened a new pull request #8685: [FLINK-12799][table] Improve expression based TableSchema extraction from DataStream/DataSet

[GitBox <gi...@apache.org>]

dawidwys opened a new pull request #8685: [FLINK-12799][table] Improve expression based TableSchema extraction from DataStream/DataSet
URL: https://github.com/apache/flink/pull/8685
 
 
   ## What is the purpose of the change
   
   We should improve the extraction of TableSchema from DataStream/DataSet. Currently it is split into a few stages:
   
       Extract types ignoring time attributes via FieldInfoUtils#getFieldInfo
       Extract the rowtime and proctime positions via StreamTableEnvImpl#validateAndExtractTimeAttributes
       Adjust the indices from #1 using information from #2
   
   All that could happen in a single pass. This will also deal with the porting/removing of a few methods from StreamTableEnvImpl.
   
   ## Brief change log
   
     - Time attributes are also handled during the first pass of `FieldInfoUtils#getFieldInfo`
     - Changed few exceptions types from `TableException` to `ValidationException` as they are thrown when the user provided information is invalid rather than some internal error happens.
     - Fixed checking that no time attributes where provided in `org.apache.flink.table.api.BatchTableEnvImpl#asQueryOperation`
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services