You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by connorgorman <gi...@git.apache.org> on 2016/06/12 23:28:58 UTC

[GitHub] thrift pull request #1026: THRIFT-3851

GitHub user connorgorman opened a pull request:

    https://github.com/apache/thrift/pull/1026

    THRIFT-3851

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/connorgorman/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1026
    
----
commit 1265a71216a439f8361373233c179e151222c681
Author: Connor Gorman <cg...@medallia.com>
Date:   2016-06-12T22:52:07Z

    THRIFT-3851

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1026: THRIFT-3851

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1026


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1026: THRIFT-3851

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1026
  
    We can ignore the failed apache jenkins build - as such this one looks okay from a build perspective.  I would like someone with some go experience to code review it however.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---