You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/23 12:29:26 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4035: Improve google-bigquery test coverage #3949
JiriOndrusek opened a new pull request, #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035
fixes https://github.com/apache/camel-quarkus/issues/3949, https://github.com/apache/camel-quarkus/issues/2057
Test `sqlCrudOperations` is disabled until Camel 18.3 is adopted (follow-up issue - https://github.com/apache/camel-quarkus/issues/4029)
Cover of various authentication approaches is covered by google-pubsub's ticket https://github.com/apache/camel-quarkus/issues/3970 and google-bigquery's ticket https://github.com/apache/camel-quarkus/issues/4033.
Tiny part of the partitioning usecase is not covered by tests in this PR - the use of `GoogleBigQueryConstants.PARTITION_DECORATOR`. Follow-up ticket https://github.com/apache/camel-quarkus/issues/4025 is created to cover this option (if possible)
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1226933424
PR is changed to leverage `camel-quarkus-integration-wiremock-support` and do not use containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1227304548
Rebased to avoid build test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1228200129
Parameters in the format ${name} are not tested (see https://camel.apache.org/components/3.18.x/google-bigquery-sql-component.html#_uri_format). Switching to the draft to add this test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1225244545
Windows build failed because there's no docker environment there. But....
If we're using WireMock to stub the BigQuery APIs, why are we starting containers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1230226834
The small missing coverage was added (and another camel Issue discovered https://issues.apache.org/jira/browse/CAMEL-18437, which affects follow-up issue: https://github.com/apache/camel-quarkus/issues/4029)
PR is ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1225488139
There are 2 options of starting wiremock server. Programatically or via docker. I don't see any advantages for any of those options. So I went with wiremock started by docker (just because docker is heavily used in other tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4035: Improve google-bigquery test coverage #3949
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #4035:
URL: https://github.com/apache/camel-quarkus/pull/4035#issuecomment-1232588480
PR is ready for approval and merge. Failed build (ftp) is not linked to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org