You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ratandeep Ratti <rd...@gmail.com> on 2015/11/18 06:21:25 UTC
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 5:21 a.m.)
Review request for hive.
Changes
-------
Using SystemClassloder as parent of per session classloader
Summary (updated)
-----------------
HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878
Repository: hive-git
Description (updated)
-------
HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
Diffs (updated)
-----
conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f
itests/custom-udfs/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5
itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648
ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb984159526048e8dacf71d3ff8b0647394a3
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923
ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38663/diff/
Testing
-------
Thanks,
Ratandeep Ratti
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Anthony Hsu <ah...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107063
-----------------------------------------------------------
Ship it!
Revision looks good to me.
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (lines 369 - 370)
<https://reviews.apache.org/r/38663/#comment165963>
You could also use `new String[0]`.
- Anthony Hsu
On 十一月 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> -----------------------------------------------------------
>
> (Updated 十一月 18, 2015, 5:21 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
>
>
> Diffs
> -----
>
> conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f
> itests/custom-udfs/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
> itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
> itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5
> itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648
> ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb984159526048e8dacf71d3ff8b0647394a3
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923
> ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ratandeep Ratti
>
>
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Ratandeep Ratti <rd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107745
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 371)
<https://reviews.apache.org/r/38663/#comment167030>
Makes sense. ContextClassLoader will be set when ever SessionState.start() will be called (which internally will call attach).
I'll remove it from the Constructor.
- Ratandeep Ratti
On Nov. 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 5:21 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
>
>
> Diffs
> -----
>
> conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f
> itests/custom-udfs/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
> itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
> itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5
> itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648
> ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb984159526048e8dacf71d3ff8b0647394a3
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923
> ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ratandeep Ratti
>
>
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Anthony Hsu <ah...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review109782
-----------------------------------------------------------
Ship it!
Revision looks good to me.
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java (line 92)
<https://reviews.apache.org/r/38663/#comment169418>
Nit: trailing whitespace
- Anthony Hsu
On 十二月 9, 2015, 8:33 a.m., Ratandeep Ratti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> -----------------------------------------------------------
>
> (Updated 十二月 9, 2015, 8:33 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
>
>
> Diffs
> -----
>
> conf/ivysettings.xml bda842a
> itests/custom-udfs/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
> itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java 0c03a00
> itests/pom.xml 5d8249f
> itests/qtest/pom.xml 8f6807a
> ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java c01994f
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5c69fb6
> ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ratandeep Ratti
>
>
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Ratandeep Ratti <rd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 8:33 a.m.)
Review request for hive.
Changes
-------
Addressed failing tests
Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878
Repository: hive-git
Description
-------
HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
Diffs (updated)
-----
conf/ivysettings.xml bda842a
itests/custom-udfs/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java 0c03a00
itests/pom.xml 5d8249f
itests/qtest/pom.xml 8f6807a
ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java c01994f
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5c69fb6
ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38663/diff/
Testing
-------
Thanks,
Ratandeep Ratti
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Ratandeep Ratti <rd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 9:56 a.m.)
Review request for hive.
Changes
-------
Addressed Jason's comments
Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878
Repository: hive-git
Description
-------
HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
Diffs (updated)
-----
conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f
itests/custom-udfs/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5
itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648
ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb984159526048e8dacf71d3ff8b0647394a3
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923
ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38663/diff/
Testing
-------
Thanks,
Ratandeep Ratti
Re: Review Request 38663: HIVE-11878: ClassNotFoundException can
possibly occur if multiple jars are registered one at a time in Hive
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107570
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 371)
<https://reviews.apache.org/r/38663/#comment166794>
Does context class loader need to be set here? Is there some place that already sets it (attach())?
- Jason Dere
On Nov. 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 5:21 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive
>
>
> Diffs
> -----
>
> conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f
> itests/custom-udfs/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java PRE-CREATION
> itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java PRE-CREATION
> itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5
> itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648
> ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb984159526048e8dacf71d3ff8b0647394a3
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923
> ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ratandeep Ratti
>
>