You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/23 12:00:47 UTC

[GitHub] [camel-kafka-connector] omarsmak commented on pull request #1052: Convert Struct to Map

omarsmak commented on pull request #1052:
URL: https://github.com/apache/camel-kafka-connector/pull/1052#issuecomment-784151043


   > Looking at it a bit better I guess this should be a separated smt in core, which should be enabled/disable through configuration as any other smt. Not all the camel components expect a map as body, so converting each struct to map makes sense only for particular components
   
   I thought about it at first but then, the Struct itself it is something very specific to Kafka Connect and hence it is pretty useless downstream into Camel components since none will use Struct anyway and the Struct itself it is a Map with schema, then why the extra step to include the SMT since it is not needed. This PR will only convert the Struct to Map if and only if, the Schema is `Struct`, otherwise it will ignore it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org