[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #939: MINIFICPP-1409 Add default credentials provider chain support to AWS authentication

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #939:
URL: https://github.com/apache/nifi-minifi-cpp/pull/939#discussion_r529706545



##########
File path: CONTROLLERS.md
##########
@@ -35,5 +35,7 @@ default values, and whether a property supports the NiFi Expression Language.
 
 | Name | Default Value | Allowable Values | Expression Language Supported? | Description |
 | - | - | - | - | - |
-| **Access Key** | | | Yes | Specifies the AWS Access Key |
-| **Secret Key** | | | Yes | Specifies the AWS Secret Key |
+|**Use Default Credentials**|false||No|If true, uses the Default Credential chain, including EC2 instance profiles or roles, environment variables, default user credentials, etc.|
+|Access Key|||Yes|Specifies the AWS Access Key|

Review comment:
       Access key being required seems to be a bit strange to me when I can use default credentials.
   
   I have a feeling that we need custom validation here: either both keys should be provided or default cred should be used. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org