You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2023/04/25 06:17:23 UTC
[GitHub] [doris] kaka11chen opened a new pull request, #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
kaka11chen opened a new pull request, #19043:
URL: https://github.com/apache/doris/pull/19043
# Proposed changes
## Problem summary
In `XXXDecoder::decode_values():`
```
while (size_t run_length = select_vector.get_next_run<has_filter>(&read_type)) {
...
}
```
It will call `get_next_run()`, need to check `_has_filter` in the loop.
```
size_t get_next_run(DataReadType* data_read_type) {
if (_has_filter) {
} else {
}
}
```
It is unnecessary. So optimize it by adding `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1521307890
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1525689597
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1521367129
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.92 seconds
stream load tsv: 429 seconds loaded 74807831229 Bytes, about 166 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230425081803_clickbench_pr_134684.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1521215904
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1525689422
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19043:
URL: https://github.com/apache/doris/pull/19043#issuecomment-1525689488
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #19043: [Optimize](parquet-reader) Add `has_filter` template param in `get_next_run()` to decrease `_has_filter` condition checking count in the loop.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #19043:
URL: https://github.com/apache/doris/pull/19043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org