You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Will Glass-Husain (JIRA)" <ji...@apache.org> on 2005/09/18 23:59:54 UTC
[jira] Updated: (VELOCITY-266) change AbstractContext.internalRemove() to have consistent key type
[ http://issues.apache.org/jira/browse/VELOCITY-266?page=all ]
Will Glass-Husain updated VELOCITY-266:
---------------------------------------
Bugzilla Id: (was: 28605)
Summary: change AbstractContext.internalRemove() to have consistent key type (was: Inconsistent key types)
type: Improvement (was: Bug)
Description:
org.apache.velocity.context.AbstractContext.internalRemove(Object key) uses an
argument type of java.lang.Object for the key. This is inconsistent with other
methods (internalGet, internalPut, internalContainsKey), which all use a type
of java.lang.String for the key.
Of course, this will probably require deprecating it, but maybe there's still
time to fix it, assuming few users have implemented their own.
- Jerry Oberle
perl -e 'printf "%silto%c%sberle%cearthlink%cnet%c", "ma", 58, "go", 64, 46,
10;' # Sorry but I do not know whether spammers can harvest addresses from here
was:
org.apache.velocity.context.AbstractContext.internalRemove(Object key) uses an
argument type of java.lang.Object for the key. This is inconsistent with other
methods (internalGet, internalPut, internalContainsKey), which all use a type
of java.lang.String for the key.
Of course, this will probably require deprecating it, but maybe there's still
time to fix it, assuming few users have implemented their own.
- Jerry Oberle
perl -e 'printf "%silto%c%sberle%cearthlink%cnet%c", "ma", 58, "go", 64, 46,
10;' # Sorry but I do not know whether spammers can harvest addresses from here
Environment:
Operating System: other
Platform: All
was:
Operating System: other
Platform: All
Assign To: (was: Velocity-Dev List)
Priority: Trivial (was: Major)
Thanks for the suggestion. It's aminor enough issue (internal API change) that I'm going to put this as "unscheduled" until someone submits a patch.
> change AbstractContext.internalRemove() to have consistent key type
> -------------------------------------------------------------------
>
> Key: VELOCITY-266
> URL: http://issues.apache.org/jira/browse/VELOCITY-266
> Project: Velocity
> Type: Improvement
> Components: Source
> Versions: 1.0-Release
> Environment: Operating System: other
> Platform: All
> Reporter: Gerard Oberle
> Priority: Trivial
>
> org.apache.velocity.context.AbstractContext.internalRemove(Object key) uses an
> argument type of java.lang.Object for the key. This is inconsistent with other
> methods (internalGet, internalPut, internalContainsKey), which all use a type
> of java.lang.String for the key.
> Of course, this will probably require deprecating it, but maybe there's still
> time to fix it, assuming few users have implemented their own.
> - Jerry Oberle
> perl -e 'printf "%silto%c%sberle%cearthlink%cnet%c", "ma", 58, "go", 64, 46,
> 10;' # Sorry but I do not know whether spammers can harvest addresses from here
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org