[arrow] branch master updated: ARROW-1821: [INTEGRATION] Add integration test case for when Field has zero null count and optional validity buffer

[we...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new ca3acdc  ARROW-1821: [INTEGRATION] Add integration test case for when Field has zero null count and optional validity buffer
ca3acdc is described below

commit ca3acdc138b1ac27c9111b236d33593988689a20
Author: Bryan Cutler <cu...@gmail.com>
AuthorDate: Thu Nov 16 00:07:13 2017 -0500

    ARROW-1821: [INTEGRATION] Add integration test case for when Field has zero null count and optional validity buffer
    
    Currently when a Field has null count = 0, C++ will omit the validity buffer as it is optional in this case.  Testing for #1316 was failing because Java was not handling this properly.  This PR adds an explicit test to ensure this is being tested and easier to locate possible issues.
    
    Author: Bryan Cutler <cu...@gmail.com>
    
    Closes #1323 from BryanCutler/integration-test-optional-validity-buffer-ARROW-1821 and squashes the following commits:
    
    4295660d [Bryan Cutler] expanded simple.json static test file to include field with null count = 0
---
 integration/data/simple.json | 48 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/integration/data/simple.json b/integration/data/simple.json
index fb903e7..bc89499 100644
--- a/integration/data/simple.json
+++ b/integration/data/simple.json
@@ -61,6 +61,54 @@
           "DATA": ["aa", "", "", "bbb", "cccc"]
         }
       ]
+    },
+    {
+      "count": 5,
+      "columns": [
+        {
+          "name": "foo",
+          "count": 5,
+          "VALIDITY": [1, 1, 1, 1, 1],
+          "DATA": [1, 2, 3, 4, 5]
+        },
+        {
+          "name": "bar",
+          "count": 5,
+          "VALIDITY": [1, 1, 1, 1, 1],
+          "DATA": [1.0, 2.0, 3.0, 4.0, 5.0]
+        },
+        {
+          "name": "baz",
+          "count": 5,
+          "VALIDITY": [1, 1, 1, 1, 1],
+          "OFFSET": [0, 2, 3, 4, 7, 11],
+          "DATA": ["aa", "b", "c", "ddd", "eeee"]
+        }
+      ]
+    },
+    {
+      "count": 5,
+      "columns": [
+        {
+          "name": "foo",
+          "count": 5,
+          "VALIDITY": [0, 0, 0, 0, 0],
+          "DATA": [1, 2, 3, 4, 5]
+        },
+        {
+          "name": "bar",
+          "count": 5,
+          "VALIDITY": [0, 0, 0, 0, 0],
+          "DATA": [1.0, 2.0, 3.0, 4.0, 5.0]
+        },
+        {
+          "name": "baz",
+          "count": 5,
+          "VALIDITY": [0, 0, 0, 0, 0],
+          "OFFSET": [0, 0, 0, 0, 0, 0],
+          "DATA": ["", "", "", "", ""]
+        }
+      ]
     }
   ]
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@arrow.apache.org" <co...@arrow.apache.org>'].