[jira] [Work logged] (BEAM-9182) Support NULL parameter in BeamZetaSqlCalcRel

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-9182?focusedWorklogId=467646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467646 ]

ASF GitHub Bot logged work on BEAM-9182:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Aug/20 00:28
            Start Date: 07/Aug/20 00:28
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #12483:
URL: https://github.com/apache/beam/pull/12483#discussion_r466754168



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##########
@@ -147,4 +165,35 @@ public int hashCode() {
       return super.hashCode();
     }
   }
+
+  private static class NamedDynamicParam extends SqlDynamicParam {

Review comment:
       nit: AutoValue might save you some boilerplate (equals, hashcode) in this class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 467646)
    Remaining Estimate: 0h
            Time Spent: 10m

> Support NULL parameter in BeamZetaSqlCalcRel
> --------------------------------------------
>
>                 Key: BEAM-9182
>                 URL: https://issues.apache.org/jira/browse/BEAM-9182
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql-zetasql
>            Reporter: Robin Qiu
>            Assignee: Robin Qiu
>            Priority: P3
>              Labels: stale-assigned
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After we migrate to BeamZetaSqlCalcRel, query parameters that are NULL values will stop working. I believe we need to fix this issue soon in order to make query parameters work end to end.
> cc: [~apilloud] [~ibzib] [~kenn]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)