[GitHub] [solr] dsmiley commented on a diff in pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r947297013


##########
solr/solrj/build.gradle:
##########
@@ -50,20 +41,15 @@ dependencies {
   implementation 'org.apache.httpcomponents:httpclient'
   implementation 'org.apache.httpcomponents:httpcore'
 
-  implementation('org.apache.zookeeper:zookeeper', {
-    exclude group: "org.apache.yetus", module: "audience-annotations"
-    exclude group: "log4j", module: "log4j"
-    exclude group: "org.slf4j", module: "slf4j-log4j12"
-  })
-  implementation ('org.apache.zookeeper:zookeeper-jute') {
-    exclude group: 'org.apache.yetus', module: 'audience-annotations'
-  }
-
   testImplementation project(':solr:test-framework')
   testImplementation project(':solr:core')
   testImplementation project(':solr:solrj')
   testRuntimeOnly project(':solr:modules:sql')
 
+  // ideally ZK centric tests move to solrj-zookeeper but sometimes we depend on ZK here anyway

Review Comment:
   Umm; I don't care enough any way.  I did call it out in the PR conversation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org