You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/18 15:55:33 UTC

[jira] [Commented] (CB-10833) Deduplicate common logic for plugin installation/uninstallation in platforms

    [ https://issues.apache.org/jira/browse/CB-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201577#comment-15201577 ] 

ASF GitHub Bot commented on CB-10833:
-------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-android/pull/282

    CB-10833 Reuse plugin installation logic from cordova-common

    DO NOT MERGE
    
    This PR is for demo purpose only and shows how the platform code will look like after plugin adding/removal functionality is moved into `cordova-common`.  See apache/cordova-lib#414 for required changes in `cordova-lib`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-android CB-10833

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #282
    
----
commit 71460ecf7b8108b569b9d716b1410c23cea65382
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-09T14:46:07Z

    CB-10822 Deduplicate plugin_metadata logic to cordova-common

commit 20cbaed5e30dc4bda13f7823555c2dd08b780d0b
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-10T11:14:42Z

    Upgrade to latest common from CB-10822

commit 15ad9327a82ee009fe6c33acea1199fdf34432b3
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-10T08:35:18Z

    Update platform to use PluginManager from common

commit 435acfe926f593f111cd68550b2bef83fe5a051c
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-10T09:12:19Z

    Upgrade cordova-common

commit e1cf50fd8d0737d71b21eb82c1abbeee508f29d7
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-10T10:02:13Z

    Instantiate munger and platformJson when needed only

commit e3e4eb741bb114ac93f404dca2f692bb255a9beb
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-03-10T11:49:21Z

    Upgrade cordova-common

----


> Deduplicate common logic for plugin installation/uninstallation in platforms
> ----------------------------------------------------------------------------
>
>                 Key: CB-10833
>                 URL: https://issues.apache.org/jira/browse/CB-10833
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Android, CordovaCommon, iOS, Windows
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org