[GitHub] [incubator-ponymail] sbp commented on pull request #517: Add DKIM style ID generation

[GitBox <gi...@apache.org>]

sbp commented on pull request #517:
URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-687210087


   @sebbASF 
   
   The test that you linked to also produces equal hashes when modified to use the current Ponymail recommended `cluster` generator. The modified test is included below for independent verification. Given that `cluster` and `dkim` exhibit the same behaviour, why is `cluster` included and explicitly recommended but `dkim` regarded as unsuitable?
   
   ```
   generators:
     # Identical mails, different archivers
     # N.B. Should be different from below
     corpus/ponymail-dev-1079-mailarchiesao.mbox:
     corpus/ponymail-dev-1079-mboxvm.mbox:
       cluster:
       - index: 0
         message-id: <CA...@mail.gmail.com>
         generated: ra504b0e636a1ac3de84a3372744b5738bc6a9e34a28645cf94855d5f@<dev.ponymail.apache.org>
     # Identical mails, different archivers
     # N.B. Should be different from above
     corpus/ponymail-dev-1080-mailarchiesao.mbox:
     corpus/ponymail-dev-1080-mboxvm.mbox:
     corpus/ponymail-dev-1080-listsao.mbox:
       cluster:
       - index: 0
         message-id: <CA...@mail.gmail.com>
         generated: ra504b0e636a1ac3de84a3372744b5738bc6a9e34a28645cf94855d5f@<dev.ponymail.apache.org>
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org