You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2020/07/08 16:49:00 UTC
[jira] [Updated] (CASSANDRA-15930) Follow up CASSANDRA-15685 - IR
does not wait for ack on commit and notifies caller of success, which can
lead to user submitting preview which could conflict
[ https://issues.apache.org/jira/browse/CASSANDRA-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Capwell updated CASSANDRA-15930:
--------------------------------------
Summary: Follow up CASSANDRA-15685 - IR does not wait for ack on commit and notifies caller of success, which can lead to user submitting preview which could conflict (was: Follow up CASSANDRA-15685)
> Follow up CASSANDRA-15685 - IR does not wait for ack on commit and notifies caller of success, which can lead to user submitting preview which could conflict
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15930
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15930
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Ekaterina Dimitrova
> Priority: Normal
>
> While working on CASSANDRA-15685, we acknowledged that there is an edge case not handled. If we try to run
> Preview repair isn't allowed to be run concurrently with IR. If we run it right after IR and IR completes before the completion message is handled on the participant; the below is impacted by this race condition.
> {code:java}
> nodetool repair foo bar
> # does not look to be running concurrently with the above IR, since it was notified of success
> # but the commit message may not have been seen yet which cause this to be concurrent with the above
> nodetool repair foo bar --validate
> {code}
> See here [https://github.com/apache/cassandra/blob/ec1808a34f9aa5ae0b956c1527828566f4ba2be5/src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java#L234-L244]. We send the message but don't make sure its ack on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org