You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/06/28 11:43:49 UTC
[GitHub] [superset] kgabryje opened a new pull request, #24542: fix(native-filters): Infinite load when filter with default first value is out of scope in horizontal bar
kgabryje opened a new pull request, #24542:
URL: https://github.com/apache/superset/pull/24542
### SUMMARY
When user added a native filter with "Select first filter value by default" checked and set a scope to a PR that's initially out of scope, the dashboard won't load if the native filters bar is in horizontal mode.
This PR fixes it by setting `forceRender` on the dropdown content in horizontal bar if there is a filter with the option selected.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/apache/superset/assets/15073128/24ac7bdf-561d-47d0-be13-75d8eb89e467
After:
https://github.com/apache/superset/assets/15073128/53d3b6b9-e00d-45f8-a05c-bcd4d50e4244
### TESTING INSTRUCTIONS
1. Create a dashboard and add two tabs to it
2. Add one chart to each tab, and a third chart under the Tabs element.
3. Create two dashboard filters with with "Select first filter value by default" option checked: one mapped to Tab 1 and the chart outside tabs and the other only mapped to Tab 2.
4. Save filter changes.
5. Change the filter bar orientation to Horizontal.
6. Navigate back to Dashboards and access it from the list.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24542: fix(native-filters): Infinite load when filter with default first value is out of scope in horizontal bar
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24542:
URL: https://github.com/apache/superset/pull/24542#issuecomment-1611322324
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24542](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0976066) into [master](https://app.codecov.io/gh/apache/superset/commit/a846e8a58d21f6e854e2b970c4878782d2ac9356?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a846e8a) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 0976066 differs from pull request most recent head fb0a978. Consider uploading reports for the commit fb0a978 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24542 +/- ##
=======================================
Coverage 58.22% 58.22%
=======================================
Files 1903 1904 +1
Lines 74026 74027 +1
Branches 8118 8118
=======================================
+ Hits 43100 43101 +1
Misses 28815 28815
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.74% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `65.00% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `69.73% <ø> (ø)` | |
| [...perset-frontend/src/components/Popover/Popover.tsx](https://app.codecov.io/gh/apache/superset/pull/24542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9Qb3BvdmVyLnRzeA==) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #24542: fix(native-filters): Infinite load when filter with default first value is out of scope in horizontal bar
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #24542:
URL: https://github.com/apache/superset/pull/24542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org