You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/06/22 20:17:22 UTC
Review Request 67706: Fix style of TaskConfigSummary.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67706/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Repository: aurora
Description
-------
Fix style of TaskConfigSummary.
Diffs
-----
ui/src/main/js/components/TaskConfigSummary.js f03d44d3b1d71e4bf06b6bf1156d6bf8d251bb70
Diff: https://reviews.apache.org/r/67706/diff/1/
Testing
-------
Tested on vagrant.
File Attachments
----------------
Before
https://reviews.apache.org/media/uploaded/files/2018/06/22/7f7b45b4-e5d2-49b6-8248-d91cf2d2c3b7__Screen_Shot_2018-06-22_at_1.14.31_PM.png
After
https://reviews.apache.org/media/uploaded/files/2018/06/22/144e4760-3b87-4f38-9883-f5453bd420a3__Screen_Shot_2018-06-22_at_1.16.05_PM.png
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67706: Fix style of TaskConfigSummary.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67706/#review205249
-----------------------------------------------------------
Ship it!
Master (8508aec) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 22, 2018, 8:17 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67706/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 8:17 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix style of TaskConfigSummary.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js f03d44d3b1d71e4bf06b6bf1156d6bf8d251bb70
>
>
> Diff: https://reviews.apache.org/r/67706/diff/1/
>
>
> Testing
> -------
>
> Tested on vagrant.
>
>
> File Attachments
> ----------------
>
> Before
> https://reviews.apache.org/media/uploaded/files/2018/06/22/7f7b45b4-e5d2-49b6-8248-d91cf2d2c3b7__Screen_Shot_2018-06-22_at_1.14.31_PM.png
> After
> https://reviews.apache.org/media/uploaded/files/2018/06/22/144e4760-3b87-4f38-9883-f5453bd420a3__Screen_Shot_2018-06-22_at_1.16.05_PM.png
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67706: Fix style of TaskConfigSummary.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67706/#review205252
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 22, 2018, 8:17 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67706/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 8:17 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix style of TaskConfigSummary.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js f03d44d3b1d71e4bf06b6bf1156d6bf8d251bb70
>
>
> Diff: https://reviews.apache.org/r/67706/diff/1/
>
>
> Testing
> -------
>
> Tested on vagrant.
>
>
> File Attachments
> ----------------
>
> Before
> https://reviews.apache.org/media/uploaded/files/2018/06/22/7f7b45b4-e5d2-49b6-8248-d91cf2d2c3b7__Screen_Shot_2018-06-22_at_1.14.31_PM.png
> After
> https://reviews.apache.org/media/uploaded/files/2018/06/22/144e4760-3b87-4f38-9883-f5453bd420a3__Screen_Shot_2018-06-22_at_1.16.05_PM.png
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67706: Fix style of TaskConfigSummary.
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67706/#review205254
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On June 22, 2018, 8:17 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67706/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 8:17 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix style of TaskConfigSummary.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js f03d44d3b1d71e4bf06b6bf1156d6bf8d251bb70
>
>
> Diff: https://reviews.apache.org/r/67706/diff/1/
>
>
> Testing
> -------
>
> Tested on vagrant.
>
>
> File Attachments
> ----------------
>
> Before
> https://reviews.apache.org/media/uploaded/files/2018/06/22/7f7b45b4-e5d2-49b6-8248-d91cf2d2c3b7__Screen_Shot_2018-06-22_at_1.14.31_PM.png
> After
> https://reviews.apache.org/media/uploaded/files/2018/06/22/144e4760-3b87-4f38-9883-f5453bd420a3__Screen_Shot_2018-06-22_at_1.16.05_PM.png
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>