You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/11/17 04:31:27 UTC
[PR] GH-38757: [C#] Implement common interfaces for structure arrays and record batches [arrow]
CurtHagenlocher opened a new pull request, #38759:
URL: https://github.com/apache/arrow/pull/38759
### What changes are included in this PR?
New interface IStructType is implemented by both Schema and StructType.
New interface IArrowStructArray is implemented by both RecordBatch and StructArray.
These changes make it easier to write code which handles both types of structures, which are virtually identical to each other.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
New interfaces have been added to access existing structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38757: [C#] Implement common interfaces for structure arrays and record batches [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #38759:
URL: https://github.com/apache/arrow/pull/38759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38757: [C#] Implement common interfaces for structure arrays and record batches [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38759:
URL: https://github.com/apache/arrow/pull/38759#issuecomment-1817296613
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c32d2266bfc2e8730512fa8ad618502ded99b1bc.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18804221846) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38757: [C#] Implement common interfaces for structure arrays and record batches [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #38759:
URL: https://github.com/apache/arrow/pull/38759#issuecomment-1816549607
Hmm... would be good to unify the visitors too so you can walk a record batch and use the same handler for the top-level structure and the nested structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38757: [C#] Implement common interfaces for structure arrays and record batches [arrow]
Posted by "davidhcoe (via GitHub)" <gi...@apache.org>.
davidhcoe commented on PR #38759:
URL: https://github.com/apache/arrow/pull/38759#issuecomment-1817197928
> w interface IStructType is implemented by both Schema and StructType.
Overall, I think this change makes sense, considering what is needed in ADBC and that C++ as both a To/From StructArray method on RecordBatch. I prefer the `IArrowRecord` and `IRecordType` to the original proposed naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org