StandardSession activate()/passivate() are broken

[Jess Holle <je...@ptc.com>]

It appears that the activate() and passivate() routines of 
StandardSession are not functioning properly.  [I've only tested 5.0.30, 
but 5.5.x seem to have identical erroneous code.]

These methods /are /called, but do not fire appropriate HttpSessionEvent 
events.  A comparison of these routines to tellNew() and expire() is 
rather telling.

I plan to rework this code along the lines of tellNew() and expire() to 
get proper functionality

--
Jess Holle

Re: [PATCH] Re: StandardSession activate()/passivate() are broken

[Jess Holle <je...@ptc.com>]

Also I notice that when PersistentManager is used that my 
sessionDestroyed() method is called multiple times (twice actually) 
whenever a session is being expired from store (i.e. upon removal of old 
passivated session data).

I am patching (crudely) around this for now, but I thought I'd bring 
this to everyone else's attention.

--
Jess Holle

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org

[PATCH] Re: StandardSession activate()/passivate() are broken

[Jess Holle <je...@ptc.com>]

Attached is a patch (against the latest 5.5.x source) that addresses 
this issue.

--
Jess Holle

Jess Holle wrote:

> It appears that the activate() and passivate() routines of 
> StandardSession are not functioning properly.  [I've only tested 
> 5.0.30, but 5.5.x seem to have identical erroneous code.]
>
> These methods /are /called, but do not fire appropriate 
> HttpSessionEvent events.  A comparison of these routines to tellNew() 
> and expire() is rather telling.
>
> I plan to rework this code along the lines of tellNew() and expire() 
> to get proper functionality
>
> --
> Jess Holle