You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Mike Drob (Jira)" <ji...@apache.org> on 2020/09/03 17:52:00 UTC

[jira] [Created] (LUCENE-9504) DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

Mike Drob created LUCENE-9504:
---------------------------------

             Summary: DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking
                 Key: LUCENE-9504
                 URL: https://issues.apache.org/jira/browse/LUCENE-9504
             Project: Lucene - Core
          Issue Type: Improvement
          Components: core/index
            Reporter: Mike Drob


{{DocumentsWriterDeleteQueue.forceApplyGlobalSlice}} is only called from {{getBufferedUpdateTermsSize}} so we end up doing double the locking. It's not a huge problem because re-entrant locks are cheap, but we can probably unwrap the methods a little bit here.

This may impact HotSpot inlining, I haven't tried measuring that yet. If that is a concern, please let me know.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org